Bug 443564
| Summary: | FEAT: Match the new db schema of bz3.0 [#8 TABLE namedqueries] | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | XINSUN <xisun> | ||||||||
| Component: | Hardware Catalog | Assignee: | XINSUN <xisun> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yu Shao <yshao> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 5 | CC: | bxu, dkl, efeng, kbaker, nelhawar, rlandry, tfu, xiqin, ykun, yshao | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | 3.2rh-20080801.1 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2008-08-04 17:56:35 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 443456 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 303738 [details]
The patch to fix : 8.1 Delete the field linkinfooter from table namedqueries
The linkinfooter is used in the template file :
"template/en/default/global/useful-links.html.tmpl"
:
=============================================================================
[% FOREACH q = user.queries %]
[% IF q.linkinfooter %]
[% " | " IF print_pipe %]
<a href="buglist.cgi?cmdtype=runnamed&namedcmd=[% q.name FILTER
url_quote %]"><nobr>[% q.name FILTER html %]</nobr></a>
[% print_pipe = 1 %]
[% END %]
[% END %]
====================================================================================
The above template file is not used in the hwcert catalog, So remove the field
linkinfooter from the select sql query. pls refer to the patch.
Best Regards!
Nicho
patch looks good to me nicho, maybe also here is a good idea to remove the code refering to linkfooter from the template/en/default/global/useful-links.html.tmpl Cheers, Noura Created attachment 304100 [details]
Patch improve:
Remove the code
refering to linkfooter from the
template/en/default/global/useful-links.html.tmpl
Pls review,
Nicho
Created attachment 304130 [details]
Patch Improve:
Created attachment 304131 [details]
Patch Improve:
Patch looks good, Thanks nicho. Please commit this change to CVS and set the status to MODIFIED. tested and run good |
8. Relate to TABLE namedqueries need to change list below: 8.1 Delete the field linkinfooter from table namedqueries Added : N/A Removed: FIELD namedqueries.linkinfooter