Bug 443871 (perl-CPAN-Mini)
Summary: | Review Request: perl-CPAN-Mini - Create a minimal mirror of CPAN | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Xavier Bachelot <xavier> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | xavier:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/CPAN-Mini/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-30 20:56:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Chris Weyl
2008-04-23 19:40:09 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=579632 SRPM URL: http://fedora.biggerontheinside.net/review/perl-CPAN-Mini-0.568-2.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-CPAN-Mini.spec Update to 0.570. http://koji.fedoraproject.org/koji/taskinfo?taskID=616528 SRPM URL: http://fedora.biggerontheinside.net/review/perl-CPAN-Mini-0.570-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-CPAN-Mini.spec + source files match upstream : 9e32e5749f315b1dfb2b3568a13621f9 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text is included. - latest version is being packaged. 0.571 is released. - BuildRequires are proper. BuildRequires: perl >= 1:5.6.0 is not needed + %clean is present. + package builds in mock. + package installs properly + rpmlint is silent - final provides and requires are sane Requires perl >= 0:5.006 due to the BR: on perl (see above) + %check is present and all tests pass + owns the directories it creates + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. %description is truncated Updated per comment #4: SRPM URL: http://fedora.biggerontheinside.net/review/perl-CPAN-Mini-0.571-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-CPAN-Mini.spec new source md5sum (matches upstream) : 0fcaa2f7ee4872c51ae62620ec04f221 Still requires perl >= 0:5.006 sed -i -e '/use 5.006;/d' Makefile.PL fixes it, but this is harmless. Looks good, APPROVED. New Package CVS Request ======================= Package Name: perl-CPAN-Mini Short Description: Create a minimal mirror of CPAN Owners: cweyl Branches: F-7, F-8, F-9, devel InitialCC: perl-sig cvs done, except for F-7 branch (We are no longer doing F-7 branches) do you really need one? (In reply to comment #8) > cvs done, except for F-7 branch (We are no longer doing F-7 branches) do you > really need one? Not really -- just part of my "request branch" script. I wasn't aware we'd stopped doing F-7 branches; I'll drop that from the script... |