Bug 444019

Summary:	Review Request: perl-PHP-Serialization - Converts between PHP's serialize() output and the equivalent Perl structure
Product:	[Fedora] Fedora	Reporter:	Jason Tibbitts <j>
Component:	Package Review	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, fedora-package-review, notting
Target Milestone:	---	Flags:	rjones: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-09 20:21:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jason Tibbitts 2008-04-24 16:15:43 UTC

Spec URL: http://www.math.uh.edu/~tibbs/rpms/perl-PHP-Serialization/perl-PHP-Serialization.spec
SRPM URL:
http://www.math.uh.edu/~tibbs/rpms/perl-PHP-Serialization/perl-PHP-Serialization-0.27-1.fc9.src.rpm
Description:
  Provides a simple, quick means of serializing perl memory structures
  (including object data!) into a format that PHP can deserialize() and
  access, and vice versa.

Builds fine in rawhide, all tests pass and rpmlint is silent.

Comment 1 Richard W.M. Jones 2008-05-12 09:06:36 UTC

+ rpmlint output

  (no rpmlint output)

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
  (yes, in README)
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  yes: 2fb3f63071c5c2119b4eebe39b329684
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
  yes, built in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=604366
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
n/a does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if available
+ reviewer should build the package in mock
  (built in Koji)
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

==========

No problems at all so APPROVED.

Comment 2 Jason Tibbitts 2008-05-28 19:42:49 UTC

Somehow I managed to miss this, because it's still in the NEW state, but it's
taken care of now, thanks.

I did my own CVS.

Comment 3 Martin Ebourne 2008-07-21 21:57:52 UTC

This is in rawhide - presumably you can close it now?