Bug 444356
Summary: | Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Terje Røsten <terje.rosten> |
Component: | Package Review | Assignee: | Hans Ulrich Niedermann <rhbugs> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | admiller, fedora-package-review, markmc, matt_domsch, notting, rhbugs |
Target Milestone: | --- | Flags: | rhbugs:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-07 16:45:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Terje Røsten
2008-04-27 18:03:21 UTC
New release upstream, new package: spec: http://terjeros.fedorapeople.org/bpython/bpython.spec srpm: http://terjeros.fedorapeople.org/bpython/bpython-0.3.1-1.fc8.src.rpm Going to re-do the review later (first review eaten by crashing Firefox). Review Guidelines MUST items: - [OK] rpmlint output: none - [OK] package name - [OK] %{name}.spec - [OK] Packaging Guidelines - [OK] Licensing Guidelines (MIT) - [OK] License Field in spec - [OK] License text in %doc - [OK] Spec file in en_US - [OK] legible spec file - [OK] source matches upstream - [OK] compiles successfully as noarch - [OK] BuildRequires - N/A %find_lang - N/A shared libs - N/A not relocatable - [OK] directory ownership - [OK] no duplicate files in %files - [OK] proper permissions on files, %defattr present - [OK] %clean section cleans %{buildroot} - [OK] consistently uses macros - [OK] package contains code - N/A large docs - [OK] %doc files do not affect runtime behaviour - N/A header files in -devel - N/A static libs in -static - N/A foo.pc files - N/A libfoo.so.1.1 - N/A no devel package - N/A no .la archives - N/A not a GUI app - [OK] Does not own files/dirs owned by other packages - [OK] %install cleans out %{buildroot} first - [OK] all filenames are valid ASCII and thus UTF-8 Review Guidelines SHOULD items: - N/A license text - N/A no translated descriptions available - [OK] builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=594044 - N/A noarch package - [OK] appears to work - N/A no scriptlets - N/A no sub-packages - N/A no foo.pc - N/A no file dependencies Remarks on Python Packaging Guidelines: - [OK] good python_sitelib macro definition - [OK] use %{python_sitelib} - N/A Not an egg, only builds .egg-info - [OK] Includes all byte compiled files Remarks on Packaging Guidelines: - package uses second allowed choice for BuildRoot: - CFLAGS="%{optflags}"... what for in a noarch package? - desktop file: - as non-GUI app bpython does not need one - it is non-functional - ergo: why not leave it out? If you do decide to add a desktop file starting bpython in a terminal: Please use %{__install}'s -p parameter. I'd change those three, but they are OK as-is. ACCEPTED. > - package uses second allowed choice for BuildRoot: Ok, will fix. > - CFLAGS="%{optflags}"... what for in a noarch package? Copy and paste error... > - desktop file: > - as non-GUI app bpython does not need one > - it is non-functional > - ergo: why not leave it out? > If you do decide to add a desktop file starting bpython in a terminal: > Please use %{__install}'s -p parameter. > I'd change those three, but they are OK as-is. Leftover from initial package, will remove desktop file. > I'd change those three, but they are OK as-is. > ACCEPTED. Thanks! Should you change Assigned To:? New Package CVS Request ======================= Package Name: bpython Short Description: Fancy curses interface to the Python interactive interpreter Owners: terjeros Branches: F-7 F-8 F-9 InitialCC: Cvsextras Commits: yes Common practise appears to leave the bug assigned to the reviewer. cvs done. > Common practise appears to leave the bug assigned to the reviewer.
I had stale browser cache or something, bug was assigned to Nobody.
Anyway, package pending for testing in F-7, F-8 and F-9 now.
Thanks for help, Hans and Kevin!
terjeros, would you please branch and build bpython for el6? openstack-nova needs it. Package Change Request ====================== Package Name: bpython New Branches: el6 Owners: mdomsch markmc terjeros has declined to participate in EPEL, but is happy for someone else to maintain it there. Git done (by process-git-requests). Package Change Request ====================== Package Name: bpython New Branches: epel7 Owners: maxamillion Git done (by process-git-requests). |