Bug 444443 (CVE-2008-2009)

Summary: CVE-2008-2009 vorbis: insufficient validation of Huffman tree causing memory corruption in _make_decode_tree()
Product: [Other] Security Response Reporter: Tomas Hoger <thoger>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: cmontgom, jnovy, kreilly, security-response-team
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-14 07:38:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 444703    
Bug Blocks: 438125    
Attachments:
Description Flags
Patch from Monty (xiphmont) none

Description Tomas Hoger 2008-04-28 13:42:36 UTC 
Will Drewry of the Google Security Team created a set of fuzzed OGG test files
to test OGG Vorbis and Tremor implementations.  Some of them were causing memory
corruption and crash on old libvorbis versions (prior to 1.0).

Crash / corruption occurred in _make_decode_tree().  This function was removed
prior to the release of upstream version 1.0 in following changes:

https://trac.xiph.org/changeset/2959
https://trac.xiph.org/changeset/2960

Test files do not crash libvobis revision 2960 or later.
Comment 1 Tomas Hoger 2008-04-28 13:53:16 UTC 
Created attachment 303976 [details]
Patch from Monty (xiphmont)

Patch adds _check_words, a dry-run variant of _make_words, that does performs
huffman tree validation early in the stream decoding.
Comment 2 Tomas Hoger 2008-04-29 09:15:15 UTC 
Similar additional checks were committed to libvorbis trunk to reject
underpopulated Huffman trees early in the file parsing:

https://trac.xiph.org/changeset/14811
Comment 9 Tomas Hoger 2008-05-14 07:30:48 UTC 
Lifting embargo.
Comment 10 Red Hat Product Security 2008-05-14 07:38:21 UTC 
This issue was addressed in:

Red Hat Enterprise Linux:
  http://rhn.redhat.com/errata/RHSA-2008-0271.html