Bug 444833

Summary:	patch introduces off by one error (extra nullbyte)
Product:	[Fedora] Fedora	Reporter:	Till Maas <opensource>
Component:	tcpflow	Assignee:	Terje Røsten <terje.rosten>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	8
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=477163
Whiteboard:
Fixed In Version:	0.21-4.fc8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-05-10 13:52:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Till Maas 2008-04-30 21:41:36 UTC

Description of problem:
The patch in tcpflow makes it add an extra nullbyte in output files.

Version-Release number of selected component (if applicable):
tcpflow-0.21-2.fc8

How reproducible:
always

Steps to Reproduce:
1. dump a tcp connection in a file with tcpdupm -w foo.dump
2. run tcpflow -r foo.dump
  
Actual results:
every output file starts with an extra nullbyte

Expected results:
there should be no extra nullbyte.

Additional info:
The debian maintainer is planning to release a fixed version of the patch, see
the reference.

Comment 1 Till Maas 2008-05-02 08:19:33 UTC

Using the new patch from debian fixes the problem for me, if you want, I can
attach the patch here or commit it to cvs.

Comment 2 Terje Røsten 2008-05-02 11:09:55 UTC

Thanks for the report.

Could you please test the tcpflow-0.21-4.fc8 package available in koji:

 http://koji.fedoraproject.org/koji/buildinfo?buildID=47881

The new patch should be included there.

Comment 3 Fedora Update System 2008-05-03 11:53:53 UTC

tcpflow-0.21-4.fc7 has been submitted as an update for Fedora 7

Comment 4 Fedora Update System 2008-05-03 11:54:37 UTC

tcpflow-0.21-4.fc8 has been submitted as an update for Fedora 8

Comment 5 Fedora Update System 2008-05-03 11:55:20 UTC

tcpflow-0.21-4.fc9 has been submitted as an update for Fedora 9

Comment 6 Till Maas 2008-05-03 19:54:59 UTC

(In reply to comment #2)

> Could you please test the tcpflow-0.21-4.fc8 package available in koji:
> 
>  http://koji.fedoraproject.org/koji/buildinfo?buildID=47881

This packages works fine for me, i.e. fixes the bug.

Comment 7 Terje Røsten 2008-05-03 20:10:51 UTC

> This packages works fine for me, i.e. fixes the bug.

Great, it' pending for stable update now.

Comment 8 Fedora Update System 2008-05-10 13:52:16 UTC

tcpflow-0.21-4.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2008-05-13 15:28:19 UTC

tcpflow-0.21-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-07-26 06:03:31 UTC

tcpflow-0.21-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.