Bug 444973

Summary: nash nfsmount doesn't respect mount options + proposed patch
Product: Red Hat Enterprise Linux 5 Reporter: Adam Stokes <astokes>
Component: mkinitrdAssignee: Peter Jones <pjones>
Status: CLOSED ERRATA QA Contact: Alexander Todorov <atodorov>
Severity: high Docs Contact:
Priority: urgent    
Version: 5.3CC: ahecox, atodorov, bpeters, buckh, bugproxy, eswierk, hannsj_uhl, ian, jens.osterkamp, jroth, palo.simo, sfolkwil, tao
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-20 22:11:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 240745    
Bug Blocks: 391501, 455534    
Attachments:
Description Flags
A patch which will hopefully fix the issue.
none
patch witch fixes compiler error - undefined variable
none
patch to handle nfs &quot;proto=&quot; mount option correctly none

Comment 4 Peter Jones 2008-05-27 17:20:02 UTC
Created attachment 306802 [details]
A patch which will hopefully fix the issue.

I don't think the patch posted is quite correct; can the customer test with
this attached patch instead?

Comment 8 IBM Bug Proxy 2008-06-02 18:17:01 UTC
------- Comment From jroth.com 2008-06-02 14:10 EDT-------
I just applied Peter's patch and I got a undefined variable error.
I'll attach a patch which fixes this small problem.

I applied this patch on top of mkinitrd-5.1.19.6-28.src.rpm

The patch works for comma-separated mount options. But it doesn't work for
proto=tcp nor for proto=udp

proto=tcp,nolock would end up with the following error:

-----
Mounting root filesystem.
unknown nfs mount parameter: proto=0
-----

As a result the nfsroot filesystem cannot be mounted.

The nfs manpage says that both, "proto=tcp" and "tcp" can be used as mount option.
Therefore proto=tcp or proto=udp should also be handled. I'll attach a patch
which fixes this issue.

Comment 9 IBM Bug Proxy 2008-06-02 18:17:09 UTC
Created attachment 307544 [details]
patch witch fixes compiler error - undefined variable

Comment 10 IBM Bug Proxy 2008-06-02 18:17:14 UTC
Created attachment 307545 [details]
patch to handle nfs &quot;proto=&quot; mount option correctly

Comment 11 RHEL Program Management 2008-06-02 20:02:29 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 16 Peter Jones 2008-07-15 18:43:26 UTC
This should be resolved in mkinitrd-5.1.19.6-29 .

Comment 20 IBM Bug Proxy 2008-10-30 10:20:41 UTC
Problem doesn't exist anymore. Bug is fixed. Thanks!

[root@localhost ~]# cat /proc/mounts
rootfs / rootfs rw 0 0
10.0.0.1:/rhel5u3beta / nfs rw,vers=3,rsize=32768,wsize=32768,hard,nolock,proto=tcp,timeo=70,retrans=3,sec=sys,addr=10.64.0.1 0 0

Comment 22 Flavio Leitner 2008-11-12 12:05:31 UTC
*** Bug 471115 has been marked as a duplicate of this bug. ***

Comment 23 Ed Swierk 2008-11-16 07:59:00 UTC
Can you please push the latest fix for this issue (http://git.fedoraproject.org/git/?p=mkinitrd;a=commit;h=069a9a57081706f42cce249837a0619c9b8aa535) to F10?  I'd prefer not to have to patch mkinitrd again.

Comment 25 errata-xmlrpc 2009-01-20 22:11:30 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0237.html

Comment 28 Peter Jones 2009-02-17 19:40:41 UTC
*** Bug 240745 has been marked as a duplicate of this bug. ***