Bug 445010 (GCVS)

Nice! I'll check this next week as I'm on business trip this week.

Unfortunately, I can't be a sponsor for you :(

This package looks fine to me, but:

* name your patch %{name}-%{version}-%{descrptions}.patch if possible
* delete Encoding from .desktop file, it has been deprecated

Hi the package and spec have been modified with your suggestions.

* The patch has been renamed %{name}-%{version}-makefile.patch for the
%{description} may be a little too long for a file name.
* Also The .desktop is modified.

You can find here the modified SRPM and SPEC :

SPEC URL : http://www.telimektar.com/rpm/xvarstar/xvarstar-0.9-1.fc9.src.rpm
SRPM URL : http://www.telimektar.com/rpm/xvarstar/xvarstar.spec

It isn't that bad if you can't be a sponsor for me, i'll try to find another one.

Can you commit this package and mark me as co-maintaner ?

PS : I have beginning packaging PyCards wich is needed for skylive.it ;) in
order to have more package to show to my potential sponsors.

Sure, I'll do that. 

the PythonCard review is going on in Bug 448435 (sorry for not mailing it our to
the list), you can start working on the skylive.it if you have time :) 

New Package CVS Request
=======================
Package Name: xvarstar
Short Description: an astronomical program used for searching GCVS
Owners: mmahut
Branches: F-8, F-9, EL-5
Cvsextras Commits: yes

Marek: You can't both review a package and maintain it... 

Can you get someone else to review? or sponsor Michael?

Michael: I might be able to sponsor you, can you provide pointers to any
pre-reviews you have done, and/or other packages you have submitted?

I've only made this package for the moment.
I've begun to work on skylive few days ago.

For the maintaining of the package I think a little mail on the astronomy-list
may help to find another reviewer.

My sponsoring can await other packages, thanks of your proposition Kevin ;)

Kevin, you're right... it would be really nice if you can review Michael's work
and sponsor him (I'm not a sponsor). Thanks Kevin :)

ok, let me know when you have a skylive package available for review?
If you get a chance to do some pre-reviews of other pending packages please let
me know... 

Ok I'll do so
I'm actually contacting skylive devs for their install scripts are quit strange,
but this is an other story ...

Pablo Martin Gomez has suggested me two minor things for the packages.
Fistr, I didn't update %release after Marek suggestions, and the ':' wasn't
well-placed into %description.

Here are updated spec and srpm :

http://www.telimektar.com/rpm/xvarstar/release-2/xvarstar.spec
http://www.telimektar.com/rpm/xvarstar/release-2/xvarstar-0.9-2.fc9.src.rpm

Also, Marek, Pablo seems to be ok for reviewing me, are you still ok for
maintaining xvarstar, and mark me as co-mainainer ?

I would like to be a co-maintainer.

Who is it going? Would it be possible to import this soon?

Sorry for the delay here. 

I was hoping to sponsor Michael, but I would like to see another package or some
pre-reviews from him. Michael: Have you had a chance to do either of those?

In the meantime if this is ready to be imported, I can do a quick review and
import it with Marek as the owner for now. 

Does that sound good? Happy to hear any other ideas or input... 

Hello Kevin, that would work for me :) We will need this for Fedora Astronomy
Spin, so we want to have it in as soon as possible for testing. Thank you.

ok, I went through my review checklist here and found just one issue...

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
9d42b1516dc487e57e1d6a1c25fd8820  xvarstar-0.9.tar.gz
9d42b1516dc487e57e1d6a1c25fd8820  xvarstar-0.9.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. The License here seems to me to be "GPLv2+"
Note that the source files all have the
"either version 2 of the License, or (at your option) any later version."
Do you see any place where this is not the case?

Michael: Can you update that? Or explain why it's not the case? 

Hi,

I'm on holiday and my internet access is very limited.
I agree with Marek as the owner of the package, for I can't work on any package
for the moment.

For the license issue, formerly i have put the GPLv2+ tag, but into a pre-review
done on #fedora-fr one suggest me to use GPL+.

I'm also awaiting an answer from skylive dev, and i have not much time to
re-mail them.

Sorry for the time that take that review.

Michael: ok, sounds fine to me... please when you have some more packages ready
feel free to email me or add my name to CC on the review bug(s). 

Marek: Do you want to look at spinning up a new package with the new license, or
see why it's not the case? 

Kevin, sorry for the delay. This has been done, new SRPM:

  http://mmahut.fedorapeople.org/reviews/xvarstar/xvarstar-0.9-3.fc8.src.rpm

ok. Sorry for my delay now. :) 

Everything looks good now to me, so this package is APPROVED.

Ping?

New Package CVS Request
=======================
Package Name: xvarstar
Short Description: an astronomical program used for searching GCVS
Owners: mmahut
Branches: F-9, EL-5
Cvsextras Commits: yes

CVS Done

Imported and built.
Thanks for the package!