Bug 445077
Summary: | Review Request: lsnipes - A text-mode maze game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans Ulrich Niedermann <rhbugs> |
Component: | Package Review | Assignee: | Jon Stanley <jonstanley> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, jonstanley, notting |
Target Milestone: | --- | Flags: | jonstanley:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.9.4-3.fc9 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-17 22:17:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Hans Ulrich Niedermann
2008-05-03 09:11:28 UTC
Scratch build results: http://koji.fedoraproject.org/koji/taskinfo?taskID=594007 rpmlint output: None. I am not sponsored, this is an unofficial review. - Package meets naming and packaging guidelines - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: $ md5sum ../SOURCES/lsnipes-0.9.4.tgz lsnipes-0.9.4.tgz ea5f41dd7942ec6e0cc1187ba78dfc5a ../SOURCES/lsnipes-0.9.4.tgz ea5f41dd7942ec6e0cc1187ba78dfc5a lsnipes-0.9.4.tgz SCRATCH BULD FOR BELOW: http://koji.fedoraproject.org/koji/taskinfo?taskID=594810 - Package needs ExcludeArch NA - BuildRequires correct OK - Spec handles locales/find_lang N/A - Package is relocatable and has a reason to be. N/A - Package has %defattr and permissions on files is good. - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) NO - Package is code or permissible content. OK - Doc subpackage needed/used. NA - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. NA - Spec has needed ldconfig in post and postun NA - .pc files in -devel subpackage/requires pkgconfig NA - .so files in -devel subpackage. NA - -devel package Requires: %{name} = %{version}-%{release} NA - .la files are removed. NA - Package is a GUI app and has a .desktop file NA - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. NA - No rpmlint output. OK $ rpmlint lsnipes-0.9.4-2.fc9.x86_64.rpm $ - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) - lsnipes = 0.9.4-2.fc9 = - libX11.so.6()(64bit) - libncurses.so.5()(64bit) - libtinfo.so.5()(64bit) SHOULD Items: - Should build in mock. OK - Should build on all supported archs OK - Should function as described. Didn't really test - it runs, display is weird, suspect that's due to the wrong fonts per upstream webpage. - Should have sane scriptlets. NA - Should have subpackages require base package with fully versioned depend. NA - Should have dist tag OK - Should package latest version OK - check for outstanding bugs on package. (For core merge reviews) NA MUST fix: Specify proper buildroot. Gack, one thing I forgot is that I had to go hunting for upstream source. It's not really linked on the webpage how to get the specific version. It's really at: http://www.ugcs.caltech.edu/~boultonj/snipes/lsnipes-0.9.4.tgz NOT what's listed in the spec. This is also a MUST fix item. * Fixed upstream source URL. * Please explain how package BuildRoot differs from preferred BuildRoot: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 I cannot see any difference, both look like %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) to me. Spec URL: http://ndim.fedorapeople.org/lsnipes/0.9.4-3.fc9/lsnipes.spec SRPM URL: http://ndim.fedorapeople.org/lsnipes/0.9.4-3.fc9/lsnipes-0.9.4-3.fc9.src.rpm Sorry, the BuildRoot is fine, and the Source0 location is fixed. I've now been sponsored, so this is APPROVED. Thank you! New Package CVS Request ======================= Package Name: lsnipes Short Description: A text-mode maze game Owners: ndim Branches: F-7 F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. lsnipes-0.9.4-3.fc9 has been submitted as an update for Fedora 9 lsnipes-0.9.4-3.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lsnipes'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-3851 lsnipes-0.9.4-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |