Bug 445085
| Summary: | Review Request: jcommon-serializer - JFree Java General Serialization Framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
| Component: | Package Review | Assignee: | Jerry James <loganjerry> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, loganjerry, notting |
| Target Milestone: | --- | Flags: | loganjerry:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-06 18:59:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Caolan McNamara
2008-05-03 11:59:12 UTC
That was sneaky putting me on the CC list. :-) I'll take it. Have you considered including ChangeLog.txt in %doc? Also, it seems weird to
have the javadocs in %{_javadocdir}/jcommon-serializer/javadoc. Can you change
this line in %install:
cp -rp javadoc $RPM_BUILD_ROOT%{_javadocdir}/%{name}
to this?
cp -rp javadoc/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}
MUST:
- rpmlint output is empty except for:
$ rpmlint jcommon-serializer-javadoc
jcommon-serializer-javadoc.prescott: W: non-standard-group Development/Documentation
- package name: OK
- spec file name: OK
- packaging guidelines: OK
- license: OK
- license file in %doc: OK
- spec file in American English: OK
- spec file is legible: OK
- sources match upstream: OK
- builds on one architecture: OK (i386)
- use of ExcludeArch: OK
- all dependencies in BuildRequires: OK
- locales handled properly: OK
- proper use of ldconfig: OK
- relocatable package: OK
- owns all directories it creates: FAIL, to fix replace this %files line:
%attr(-,root,root) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.*
with this line:
%attr(-,root,root) %{_libdir}/gcj/%{name}
- no duplicate files: OK
- permissions: OK
- %clean section: OK
- consistent use of macros: OK
- code or permissible content: OK
- large documentation in -doc: OK
- nothing in %doc needed at runtime: OK
- header files in -devel: OK
- static libraries in -static: OK
- require pkgconfig if needed: OK
- .so files in -devel: OK
- devel packages require base: OK
- no libtool archives: OK
- desktop file for GUI apps: OK
- do not own already owned files or dirs: OK
- %install cleans buildroot first: OK
- all filenames are UTF-8: OK
SHOULD:
- license text file: OK
- description and summary translations: OK
- package builds in mock: OK (tested for i386 F-8 only)
- builds on all supported architectures: did not check
- package functions as described: did not check
- sane scriptlets: OK
- subpackages require main package: OK
- pkgconfig file placement: OK
- file dependencies: OK
Summary:
1. MUST fix the gcj directory ownership issue.
2. PLEASE consider ChangeLog.txt for %doc.
3. PLEASE consider shortening the javadoc path as described above.
http://people.redhat.com/caolanm/jfreereport/jcommon-serializer.spec http://people.redhat.com/caolanm/jfreereport/jcommon-serializer-0.2.0-2.fc9.src.rpm Should sort those out Indeed it does. APPROVED New Package CVS Request ======================= Package Name: jcommon-serializer Short Description: JFree Java General Serialization Framework Owners: caolanm Branches: InitialCC: Cvsextras Commits: yes cvs done. |