Bug 445142
| Summary: | Review Request: libcapseo - Realtime encoding/decoding library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Starr <shawn.starr> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-16 04:52:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 445143 | ||
|
Description
Shawn Starr
2008-05-04 17:36:25 UTC
Quick-n-dirty initial comments:
1. this is a prerelease, so use something along the lines of:
Release: 0.1.%{snapshot}%{?dist}
instead.
2. -devel should have
Requires: %{name} = %{version}-%{release}
Requires: pkgconfig
3. -tools,
Requires: mesa-libGL
why? shouldn't this get auto-dep'd?)
4. %files tools
missing %defattr
Corrolary to 2, ditto (Req: %{name}...) for -tools subpkg.
scratch build (with most of those fixes):
http://koji.fedoraproject.org/koji/taskinfo?taskID=596625
scratch build looks good. Make changes as suggested, and I'll approve this. New package uploaded, with changes made Spec file: http://www.sh0n.net/spstarr/fedora/libcapseo/result/libcapseo.spec mock results: http://www.sh0n.net/spstarr/fedora/libcapseo/result/ Looks good, APPROVED. One small item: move ./autogen.sh to %setup section, not %build Will change that, also for BZ 445143 which has the same build process New Package CVS Request ======================= Package Name: libcapseo Short Description: Realtime encoding/decoding library Owners: spstarr Branches: F-9 InitialCC: spstarr Cvsextras Commits: yes cvs done. Commited to CVS devel, pending F-9 New Package CVS Request ======================= Package Name: libcapseo Short Description: Realtime encoding/decoding library Owners: spstarr Branches: F-8, F-9 InitialCC: spstarr Cvsextras Commits: yes Package Change Request ====================== Package Name: libcapseo New Branches: F-8 We really should make this one format, kinda silly to have to know the field template names. Ideally, we will get pkgdb to just have a form/web ui for requesting things... cvs done. libcaptury-0.3.0-0.1.20080323gitcca4e3c.fc9,libcapseo-0.2.0-0.1.20080603gita6ec446.fc9 has been submitted as an update for Fedora 9 libcaptury-0.3.0-0.1.20080323gitcca4e3c.fc9, libcapseo-0.2.0-0.1.20080603gita6ec446.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |