Bug 445261
Summary: | Review Request: icelandic-fonts - Icelandic Magical Staves | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jon Stanley <jonstanley> |
Component: | Package Review | Assignee: | Jon Stanley <jonstanley> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, fonts-bugs, notting |
Target Milestone: | --- | Flags: | nicolas.mailhot:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-02-12 03:49:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jon Stanley
2008-05-05 20:26:56 UTC
rpmlint: icelandic-fonts.noarch: W: no-documentation No documentation for a font. On the technical side same comments apply as for Brett font. *However* please contact the author and make sure he's not just digitized and transformed without authorization material posted on www.galdrasyning.is. If he actually drew the shapes himself from scratch that's probably ok. Thank you for packaging a few fonts! Any progress here? bah forgot all about it. having just one arm for now sucks - will address at a later point in my recovery from surgery :) mail sent to upstream, waiting for response Upstream has authorization to use these images. Can we get this one approved? https://bugzilla.redhat.com/show_bug.cgi?id=445261 No one cared to say that I had got authorization to use the images. Simple misunderstanding here :) This one still needs a little work. 1. don't do an otf cp in %prep, use the more elegant form you did for asana 2. please add a trace of upstream's permission in %doc. Those kinds of things tend to be lost and cause problems later New SRPM: http://jstanley.fedorapeople.org/icelandic-fonts-1.001-1.fc9.src.rpm spec is the same Added information about upstream's permission - http://www.galdrasyning.is/index.php?option=com_content&task=view&id=418&Itemid=46&lang=en Please add the copy of the http://www.galdrasyning.is/ permission text in your README (with a "taken from foo URL" header). Next thing you know they'll reorganise their website and your link will point nowhere (If they had made it a txt file we could have just Source-d it directly from this URL) I don't see a 1.001 in the OTF file I download from OFLB, just a 1.000 (will translate in 1.0 for rpm) but I may have a proxy serving an older file between me and upstream. I'd package the font preview in %doc but that's purely optional and we'll certainly need to figure a streamlined way to generate this kind of preview ourselves in all our font packages someday. But that's me being a perfectionist. The legal uncertainty has been cleared, and your package is already better than some I know. You can continue from http://fedoraproject.org/wiki/Font_package_lifecycle#3.a now APPROVED New Package CVS Request ======================= Package Name: icelandic-fonts Short Description: Font with Icelandic Magical Staves Owners: jstanley Branches: F-8 F-9 EL-4 EL-5 InitialCC: fonts-sig Cvsextras Commits: yes cvs done. This has been in for a long time, closing. |