Bug 445601
Summary: | Review Request: ruby-augeas - Ruby bindings for Augeas | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Lutterkort <lutter> |
Component: | Package Review | Assignee: | Richard W.M. Jones <rjones> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, hbrock, kevin, mtasaka, notting |
Target Milestone: | --- | Flags: | rjones:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-12 16:35:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
David Lutterkort
2008-05-07 21:55:15 UTC
rpmlint is clean except for ruby-augeas.x86_64: W: incoherent-version-in-changelog 0.0.1-1 0.1.0-1.fc9 which I will fix before importing into CVS Taking review (later today). - rpmlint output ruby-augeas.x86_64: W: incoherent-version-in-changelog 0.0.1-1 0.1.0-1.fc8 The %changelog has an obviously wrong first entry. Easy to fix. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license LGPLv2+ + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm f0a822be6e0d4ce3544904c15244a750 ruby-augeas-0.1.0.tgz + package successfully builds on at least one architecture n/a ExcludeArch bugs filed + BuildRequires list all build dependencies built in Koji to check n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock Built in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=600578 + the package should build into binary RPMs on all supported architectures - review should test the package functions as described n/a scriptlets should be sane n/a pkgconfig files should go in -devel n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin =============== APPROVED, just fix that %changelog before checking it in. New Package CVS Request ======================= Package Name: augeas Short Description: a configuration API Owners: lutter Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes This should be 'ruby-augeas' for the package ? Can you repost your cvs request with the right package name and description? Thanks. Sorry about that ... seems I haven't mastered the high art of cut&paste Fixed request: New Package CVS Request ======================= Package Name: ruby-augeas Short Description: Ruby bindings for Augeas Owners: lutter Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Please change the Source0 to full URL. http://fedoraproject.org/wiki/Packaging/SourceURL Imported and built as http://koji.fedoraproject.org/koji/buildinfo?buildID=48599 Package Change Request ====================== Package Name: ruby-augeas New Branches: EL-4, EL-5 cvs done. |