Bug 445604
Summary: | Review Request: tennix - A funny 2D tennis game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Claudio Tomasoni <claudio> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, mtasaka, notting, pablomg+fedora, paul |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-09-21 13:58:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Claudio Tomasoni
2008-05-07 22:03:33 UTC
You can fix the debuginfo by compiling with the appropriate flags and not stripping the debug data from the binary at install time: Add: sed -i -e 's/install -s/install/' makefile after %setup -q in %prep to prevent the stripping. Add: export CFLAGS="%{optflags}" before "make" in %build to set the compiler flags. You're also going to need: BuildRequires: desktop-file-utils Hi Paul, - substituted "install -s" with "install" in the makefile (I have really a lot to learn about makefiles) - used 'CFLAGS="%{optflags}" make' to build the binaries - added desktop-file-utils as build requirement (oops! forgot it!) New SPEC file and SRPM are available at Spec URL: http://www.claudiotomasoni.it/files/RPMS/tennix.spec SRPM URL: http://www.claudiotomasoni.it/files/RPMS/tennix-0.6.1-2.fc8.src.rpm (Removing NEEDSPONSOR: I will sponsor Claudio) Some comments about your spec: * The compilation succeed with "make %{?_smp_mflags}" (-j3 for me) as well with X86_64 than i386, without warnings. * Attention with "%{_datadir}/applications/*.desktop", you are owning all the desktop files, just put "fedora-%{name}.desktop" at the end. What is the status of this package? Claudio, would you still interested in importing this package into Fedora? Hello, I'm still interested in importing this package into Fedora. As already written I had some health trouble in the last months, that was the reason of my absence. Anyway, the package doesn't build in koji for dist-f10 with "make %{?_smp_mflags}" in the build section (see http://koji.fedoraproject.org/koji/taskinfo?taskID=782837). In the new SPEC and SRPM the only correction is the name of the desktop file: Spec URL: http://www.claudiotomasoni.it/files/RPMS/tennix.spec SRPM URL: http://www.claudiotomasoni.it/files/RPMS/tennix-0.6.1-3.fc9.src.rpm Well, for 0.6.1-3: * Summary - Usually the part like "Tennix! is a" is redundant for Summary * SourceURL - I recommend to use %{name}, %{version} macros (especially %{version}). With using these you probably don't have to modify SourceURL when the version is upgraded. * Macros - Use macros. /usr must be %{_prefix}. ! Timestamp - Would you consider to add ---------------------------------------------------------- sed -i -e 's|install -m|install -p -m|' makefile ---------------------------------------------------------- to keep timestamps on installed files as much as possible? * Icon caching - Please refer to https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache All fixes suggested done in: Spec URL: http://www.claudiotomasoni.it/files/RPMS/tennix.spec SRPM URL: http://www.claudiotomasoni.it/files/RPMS/tennix-0.6.1-4.fc9.src.rpm About "! Timestamp": ok, I'll take care of this from now on. About "* Icon caching": lesson learned (it's the second time with the same error). Good. ----------------------------------------------------------------------------- This package (tennix) is APPROVED by mtasaka ----------------------------------------------------------------------------- New Package CVS Request ======================= Package Name: tennix Short Description: A simple tennis game Owners: claudiotomasoni Branches: F-8 F-9 InitialCC: cvs done. For F-9/8, please remember to submit a request on bodhi to push the packages to repositories after rebuild on koji. Tennix has been successfully built on devel (F-10), but when I try to build it on F-8 or F-9, I get this error: koji: error: Destination tag dist-f9 is locked I will try again a later. (In reply to comment #14) > koji: error: Destination tag dist-f9 is locked If you still see this problem, please try to re-check tennix and common directory. Are you still seeing the problem? tennix-0.6.1-4.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/tennix-0.6.1-4.fc8 tennix-0.6.1-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/tennix-0.6.1-4.fc9 Re-imported, built and submitted in bodhi. Thanks! tennix-0.6.1-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. tennix-0.6.1-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |