Bug 445950

Summary: signed/unsigned comparison in the generated code.
Product: [Fedora] Fedora Reporter: Pawel Salek <pawsa>
Component: flexAssignee: Petr Machata <pmachata>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: mnewsome
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.5.35-2.fc9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-13 14:32:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch. none

Description Pawel Salek 2008-05-10 08:39:15 UTC
Description of problem:
flex generates code that compares signed and unsigned numbers. While this is
unlikely to cause problems in practice, it's nice habit to declare the variable
types properly.

Version-Release number of selected component (if applicable):
flex-2.5.35-1.fc9

How reproducible:
Always.

Steps to Reproduce:
1. Use following code:
%option noyywrap

white		[ \t]+

%%
{white} 	{ /* We ignore white characters. */ }

2. Compile using flex flex_test.l && cc -Wsign-compare lex.yy.c

  
Actual results:
lex.yy.c: In function ‘yy_get_next_buffer’:
lex.yy.c:956: warning: comparison between signed and unsigned


Expected results:
Warningless compilation.

Additional info:
I have contacted flex maintainer (srivasta at debian) on 2008-04-30 but received
no response so far.

Comment 1 Pawel Salek 2008-05-10 08:39:15 UTC
Created attachment 305010 [details]
Proposed patch.

Comment 2 Fedora Update System 2008-05-12 14:02:20 UTC
flex-2.5.35-2.fc9 has been submitted as an update for Fedora 9

Comment 3 Fedora Update System 2008-05-13 14:32:23 UTC
flex-2.5.35-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.