Bug 446410

Summary: Review Request: perl-BDB - Asynchronous Berkeley DB access
Product: [Fedora] Fedora Reporter: Nicolas Chauvet (kwizart) <kwizart>
Component: Package ReviewAssignee: Xavier Bachelot <xavier>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: xavier: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-31 13:43:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nicolas Chauvet (kwizart) 2008-05-14 15:06:26 UTC
Spec URL: 
http://kwizart.fedorapeople.org/SPECS/perl-BDB.spec
SRPM URL: 
http://rpms.kwizart.net/fedora/9/SRPMS/perl-BDB-1.45-1.fc9.kwizart.src.rpm
Description: Asynchronous Berkeley DB access

Comment 1 Parag AN(पराग) 2008-05-27 12:24:04 UTC
update package as I can see new upstream release

Comment 2 Nicolas Chauvet (kwizart) 2008-05-27 12:44:25 UTC
Spec URL: 
http://kwizart.fedorapeople.org/SPECS/perl-BDB.spec
SRPM URL: 
http://kwizart.fedorapeople.org/SRPMS/perl-BDB-1.5-1.fc8.kwizart.src.rpm
Description: Asynchronous Berkeley DB access

Updated to 1.5
http://koji.fedoraproject.org/koji/taskinfo?taskID=630296
(not yet finished at this time)

Comment 3 Xavier Bachelot 2008-05-29 12:59:21 UTC
+ source files match upstream : 0b87e6aa97465f74d21c719439c43840
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ %clean is present.
+ package builds in mock.
+ package installs properly
+ rpmlint is silent
+ final provides and requires are sane
+ %check is present and all tests pass
+ owns the directories it creates
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

looks good, APPROVED

Just a note, if upstream bumps the version like it was done for 1.45 to 1.5,
it's going to be funny...

Comment 4 Nicolas Chauvet (kwizart) 2008-05-29 13:25:15 UTC
I'm trying to contact upstream about the problem with version bump.
I may import it after i got an answear.

Thx for your the reviews.

Comment 5 Nicolas Chauvet (kwizart) 2008-05-29 15:38:34 UTC
New Package CVS Request
=======================
Package Name: perl-BDB
Short Description: Asynchronous Berkeley DB access
Owners: kwizart
Branches: F-8 F-9 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-05-30 19:58:07 UTC
cvs done.