Bug 446411
| Summary: | Review Request: perl-Event-Lib - Perl wrapper around libevent | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-27 21:39:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Chauvet (kwizart)
2008-05-14 15:07:54 UTC
Can you add BR for skipped tests
t/00_pod.........................
skipped
all skipped: Test::Pod not installed
t/00_pod_coverage................
skipped
all skipped: Test::Pod::Coverage not installed
BR: perl(Test::Pod::Coverage)
Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Event-Lib.spec SRPM URL: http://rpms.kwizart.net/fedora/9/SRPMS/perl-Event-Lib-1.03-2.fc9.kwizart.src.rpm Description: Perl wrapper around libevent Changelog: - Add Missing BR for test All tests went successful now. unable to download SRPM ping ? oops sorry I missed this review from my review list. Review: + package builds in mock (rawhide i386). koji build=http://koji.fedoraproject.org/koji/taskinfo?taskID=630225 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 90b60028f7f5836072e95c6d5b1d069e Event-Lib-1.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is All tests successful. Files=36, Tests=4280, 56 wallclock secs ( 8.13 cusr + 1.05 csys = 9.18 CPU) + Package perl-Event-Lib-1.03-2.fc10 => Provides: Lib.so perl(Event::Lib) = 1.03 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libevent-1.3e.so.1 perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) APPROVED. Thx! I Have few others perl packages waiting for review! (If you had a little time - of course feel free to ask if you need a reviewer) New Package CVS Request ======================= Package Name: perl-Event-Lib Short Description: Perl wrapper around libevent Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes cvs done. |