Bug 446414
| Summary: | Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Xavier Bachelot <xavier> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tomc, xavier |
| Target Milestone: | --- | Flags: | xavier:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-31 13:43:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Chauvet (kwizart)
2008-05-14 15:10:10 UTC
+ source files match upstream : 904f6fe4b94248b56507710b29a53873
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock ( ).
+ package installs properly
- rpmlint is silent :
file-not-utf8 /usr/share/man/man3/Gtk2::Ex::FormFactory::*.3pm.gz
- final provides and requires are sane:
These provides are bogus :
perl(Music::Album)
perl(Music::Artist)
perl(Music::Config)
perl(Music::DBI)
perl(Music::Genre)
perl(Music::Song)
This is weird as the doc files that induce that are not executable.
+ %check is present and all tests pass
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
Also, package is noarch, replace "make %{?_smp_mflags}" by a simple "make"
I have never heard that noarch package should not use parallel make. (In reply to comment #2) > I have never heard that noarch package should not use parallel > make. You're absolutely right, sorry, temporary brain outage... Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Gtk2-Ex-FormFactory.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Gtk2-Ex-FormFactory-0.65-2.fc8.kwizart.src.rpm Description: Framework for Gtk2 perl applications Changelog - Fix man3 encoding - Fix unwanted perl provides (Music::*) All the .pm under lib/ are iso8859, so rather than fixing the man page encoding in %install, I would move all of them to utf-8 in %prep. not sure this is really a blocker, I don't find anything in the guidelines. Something like that should do :
for f in $(find lib/ -name *.pm) README tutorial/README; do
cp -p ${f} ${f}.noutf8
iconv -f ISO-8859-1 -t UTF-8 ${f}.noutf8 > ${f}
touch -r ${f}.noutf8 ${f}
rm ${f}.noutf8
done
Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Gtk2-Ex-FormFactory.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Gtk2-Ex-FormFactory-0.65-3.fc8.kwizart.src.rpm Description: Framework for Gtk2 perl applications looks good, APPROVED. New Package CVS Request ======================= Package Name: perl-Gtk2-Ex-FormFactory Short Description: Framework for Gtk2 perl applications Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes cvs done. |