Bug 446800

Summary: Review Request: ebnetd - EBNET protocol server
Product: [Fedora] Fedora Reporter: Akira TAGOH <tagoh>
Component: Package ReviewAssignee: Gwyn Ciesla <gwync>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, gwync, i18n-bugs, notting, pertusus, petersen, tibbs
Target Milestone: ---Flags: gwync: fedora-review+
huzaifas: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-10-15 07:34:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Akira TAGOH 2008-05-16 06:12:39 UTC
Spec URL: http://tagoh.fedorapeople.org/ebnetd/ebnetd.spec
SRPM URL: http://tagoh.fedorapeople.org/ebnetd/ebnetd-1.0-1.fc9.src.rpm
Description:
 EBNET is a protocol to communicate to the EB library that is a C library
 for accessing "CD-ROM books".

Comment 1 Jason Tibbitts 2008-07-04 21:17:53 UTC
You'll need to remove the errant info "dir" in order for this to build.

You shouldn't include the same six documentation files in every subpackage.

That's all I see at a quick glance.

Comment 3 Tony Fu 2008-09-10 03:07:22 UTC
requested by Jens Petersen (#27995)

Comment 4 Gwyn Ciesla 2008-10-10 14:41:06 UTC
What's comment #3 about?

Anyway. . .

rpmlint on SRPM is clean.

rpmlint on RPMS:

ebhttpd.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ebnetd.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ebnetd-common.i386: W: non-standard-uid /var/lib/ebnetd ebnetd
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.

ebnetd-common.i386: W: non-standard-gid /var/lib/ebnetd ebnetd
A file in this package is owned by a non standard group. Standard groups are:
root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news,
uucp, man, games, gopher, dip, ftp, lock, nobody, users.

ebnetd-common.i386: W: non-standard-uid /var/run/ebnetd ebnetd
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.

ebnetd-common.i386: W: non-standard-gid /var/run/ebnetd ebnetd
A file in this package is owned by a non standard group. Standard groups are:
root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news,
uucp, man, games, gopher, dip, ftp, lock, nobody, users.

ndtpd.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.



These are all fine, see above.

Otherwise, everything looks great, my only other concern after a full review is the Conflicts: for ebhttpd.  Will users expect this to be on port 80 by default, period, full stop, or would it be feasible to set it to use something else by default, or recommend that to users?  It'd be as simple as modifying the xinetd file.  My preference would be to leave it as is, drop the Conflicts:, but add a ebnetd-README.fedora indicating the port 80 issues and resolutions, so that if someone wants to use this on a machine with an existing httpd/tux/whatever, then they have that option and won't be stopped by the RPM.

Comment 5 Akira TAGOH 2008-10-11 12:12:42 UTC
Thanks for the review. I'd prefer adding a document how to change the port too. updated srpm and spec file is:

Spec URL: http://tagoh.fedorapeople.org/ebnetd/ebnetd.spec
SRPM URL: http://tagoh.fedorapeople.org/ebnetd/ebnetd-1.0-3.fc9.src.rpm

Comment 6 Patrice Dumas 2008-10-11 14:47:45 UTC
Please avoid using fedora in the file name:
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Avoiding_using_fedora_or_redhat

Comment 8 Gwyn Ciesla 2008-10-13 13:03:19 UTC
Perfect.  Thanks!

APPROVED.

Comment 9 Akira TAGOH 2008-10-14 13:22:37 UTC
New Package CVS Request
=======================
Package Name: ebnetd
Short Description: EBNET protocol server
Owners: tagoh
Branches: devel F-9 F-8
InitialCC:

Comment 10 Huzaifa S. Sidhpurwala 2008-10-15 05:25:46 UTC
cvs done

Comment 11 Akira TAGOH 2008-10-15 06:07:26 UTC
unable to build the package due to "FAILED: BuildError: package ebnetd not in list for tag dist-{f10,{f9,f8}-updates-candidate}.

Comment 12 Akira TAGOH 2008-10-15 07:34:22 UTC
there seems to be a delay. it's ok now.