Bug 446814

Summary: Review Request: emacs-lookup - Emacsen interface to look up dictionaries
Product: [Fedora] Fedora Reporter: Akira TAGOH <tagoh>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dueno, fedora-package-review, i18n-bugs, notting, petersen, tibbs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-11-16 10:21:50 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description Akira TAGOH 2008-05-16 05:18:51 EDT
Spec URL: http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup.spec
SRPM URL: http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup-1.4.1-1.fc9.src.rpm
Description:

Lookup is an integrated search interface with electronic dictionaries
for Emacsen. You can use various kinds of dictionaries, such as CD-ROM books
and online dictionaries, in an efficient and effective manner.
Comment 1 Jason Tibbitts 2008-06-21 19:21:23 EDT
This fails to build in mock for me; the build completes, but the final assembly
process fails with:

error: Installed (but unpackaged) file(s) found:
   /usr/share/info/dir

It's recommended that you rm -f this; whether it is generated or not depends on
several things, but it should never be included in the package.
Comment 2 Akira TAGOH 2008-06-22 23:28:19 EDT
Thank you for catching this up. wasn't aware of that so that I didn't see that
error here. anyway fixed in:

Spec URL: http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup.spec
SRPM URL:
http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup-1.4.1-2.fc9.src.rpm
Comment 3 Jason Tibbitts 2008-06-25 00:26:25 EDT
I had intended to get back to this with some more review commentary so we didn't
have to go back and forth, but I ran out of time, sorry.

I notice that the lookup-guide.info file isn't in UTF8, and isn't in any
encoding I recognize, so it doesn't render at all for me.  (rpmlint complains
it, of course.)  Do you know what the encoding is?  Is it possible to convert to
UTF8 so that everyone can at least look at the file without having to set some
specific encoding?

I get a "406 Not Acceptable" error when visiting the URL given in the spec.  I
expect that the server is trying to present a page based on my language
settings, but none exists.  Perhaps it would be better to simply refer directly
to the Japanese page at http://openlab.jp/edict/lookup/index.html.ja. 
Unfortunately my Japanese is only good enough to read a few words (and most of
the gairaigo) on that page, but it's obviously a reasonable page to use as the
URL for this package.
 
Unfortunately this package fails to conform to many of the Emacs packaging
guidelines given in http://fedoraproject.org/wiki/Packaging/Emacs.  The
versioned dependencies are missing, the build dependencies are not correct
(although the package still builds for me), there are no separate -el packages,
etc.  There are some pretty complete templates on the guideline page which you
can copy.
Comment 4 Tony Fu 2008-09-09 23:07:27 EDT
requested by Jens Petersen (#27995)
Comment 5 Jason Tibbitts 2008-11-07 19:38:16 EST
So its been over four months since I made my comments with no response.  I will close this ticket soon if there is no further progress.
Comment 6 Daiki Ueno 2010-04-06 03:12:11 EDT
I've just packaged Lookup 2.0 beta, which is a major rewrite of 1.4 and works much more seamlessly with Emacs 23.  Here are spec and SRPM:

Spec URL:
http://www.unixuser.org/~ueno/software/fedora/lookup/emacs-lookup.spec
SRPM URL:
http://www.unixuser.org/~ueno/software/fedora/lookup/emacs-lookup-1.99.95-1.fc13.src.rpm

Notes:
- Since the upstream no longer supports XEmacs (see NEWS), I packaged it for GNU Emacs only.
- The spec file is based on the template on the Emacs packaging policy so it should not contain issues mentioned above.
- I concluded the license is GPLv3+ since the package contains both GPLv2+ and GPLv3+ files.

If it is ok, I'm available for maintaining the package.
Comment 7 Mamoru TASAKA 2010-04-06 03:25:50 EDT
(In reply to comment #6)
> If it is ok, I'm available for maintaining the package.    

If you want to import this package into Fedora, please file
a new review request and mark this ticket as a duplicate of the
new one.
Comment 8 Daiki Ueno 2010-04-06 03:40:43 EDT
Done, thanks.

*** This bug has been marked as a duplicate of bug 579662 ***