Bug 446976
| Summary: | Review Request: tkabber - Tkabber is a Free and Open Source client for the Jabber instant messaging system. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexey Lubimov <avl> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-15 07:06:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 446978 | ||
| Bug Blocks: | 201449 | ||
|
Description
Alexey Lubimov
2008-05-16 19:51:47 UTC
*** Bug 446965 has been marked as a duplicate of this bug. *** I'll review it. Initial remarks:
* Requires tktray. Do you plan to submit it for review?
* desktop-file-install - wrong vendor
* Wrong versioning scheme - should be
Version: 0.10.1
Release: 0.1.beta2%{?dist}
where Release consists of 0 (which means prerelease) ++ buildnum ++ beta2
(prerelease version) ++ %{dist}
Using this naming scheme we may ensure that application will be updated then it
will be released ( 0.10.1-[1-9] > 0.10.1-0.anything, but 0.10.1.beta2 >
0.10.1-anything)
Consider to change your spec-file according to these suggestions.
BTW This wonderful app was in my TODO-list for a long time and I'm glad to see
that now it's on the way to Fedora, finally :)
>* Requires tktray. Do you plan to submit it for review? yes. already submitted. https://bugzilla.redhat.com/show_bug.cgi?id=446978 * desktop-file-install - wrong vendor Maybe. But I don't know right value of this parameter. Any tips or suggest for this bug? At this time, I simple removed --vendor from desktop-file-install. * Wrong versioning scheme - should be fixed ftp://srv.l14.ru/pub/repo/FC/9/SPECS/tkabber.spec ftp://srv.l14.ru/pub/repo/FC/9/SRPMS/tkabber-0.10.1-0.1.beta2.fc9.src.rpm Putting this review on hold until tktray will be reviewed. As for vendor field in desktop-file-install, you should use vendor fedora, if upstream doesn't provide its own. See details here: http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6 >As for vendor field in desktop-file-install, you should use vendor fedora, if
upstream doesn't provide its own. See details here:
Oк. Fixed.
Removing NEEDSPONSOR. I am sponsoring Alexey. new version tkabber - 0.11.0 ftp://ftp.l14.ru/pub/repo/FC/9/SPECS/tkabber.spec ftp://ftp.l14.ru/pub/repo/FC/9/SRPMS/tkabber-0.11.0-1.fc9.src.rpm What is the status of this bug? Alexey Lubimov promised me in private email, that he will renew tkabber package soon. So, I think we should wait for a while. Unfortunately, initial reporter has some issues with logging in to Bugzilla and has no interest in solving them. *** This bug has been marked as a duplicate of bug 650180 *** |