Bug 447159
| Summary: | Review Request: ocsinventory - Open Computer and Software Inventory Next Generation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Xavier Bachelot <xavier> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, xavier |
| Target Milestone: | --- | Flags: | xavier:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-29 12:04:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Remi Collet
2008-05-18 11:29:53 UTC
All rpmlint warnings look ok, except this one : ocsinventory-server.noarch: E: non-standard-dir-perm /var/log/ocsinventory-server 0750 The /var/lib/ocsinventory-server directory owned by the ocsinventory-reports package should be renamed to /var/lib/ocsinventory-reports, but this has been requested upstream. It would be better to get this fixed before importing the package as the rename would require some tweaking to the conf and mysql database. + source files match upstream: 4c582d29db7777506b5cfe49f15af3c4 OCSNG_UNIX_SERVER_1.02_RC2.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. + License text included in package. + latest version is being packaged. + BuildRequires are proper. + package builds in mock. + package installs properly - rpmlint is not silent : ocsinventory.noarch: W: no-documentation ocsinventory-reports.noarch: E: non-standard-uid /var/lib/ocsinventory-server apache ocsinventory-reports.noarch: E: non-standard-uid /etc/ocsinventory/ocsinventory-reports/dbconfig.inc.php apache ocsinventory-reports.noarch: E: non-readable /etc/ocsinventory/ocsinventory-reports/dbconfig.inc.php 0640 ocsinventory-reports.noarch: E: non-standard-uid /var/lib/ocsinventory-server/download apache ocsinventory-reports.noarch: E: non-standard-uid /var/lib/ocsinventory-server/ipd apache ocsinventory-server.noarch: E: non-standard-uid /var/log/ocsinventory-server apache ocsinventory-server.noarch: E: non-standard-dir-perm /var/log/ocsinventory-server 0750 All but the last warning are OK. Please fix perms on /var/log/ocsinventory-server - final provides and requires are sane missing Requires on nmap and samba-client for ocsinventory-reports + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + scriptlets are sane. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + not a GUI app. Items to fix : - Please fix perms on /var/log/ocsinventory-server. - Please take care of the directory renaming mentioned in comment #1. - ipdiscover-util.pl requires nmap and nmblookup, provided respectively by nmap and samba-client, please add them to ocsinventory-reports requires. Patch for new path merged upstream. New version : Spec : http://remi.fedorapeople.org/ocsinventory-agent.spec SRPM : http://remi.fedorapeople.org/ocsinventory-1.02-0.5.rc2.fc8.src.rpm Patch for new path merged upstream. New version : Spec : http://remi.fedorapeople.org/ocsinventory.spec SRPM : http://remi.fedorapeople.org/ocsinventory-1.02-0.5.rc2.fc8.src.rpm All items fixed, looks good, APPROVED. New Package CVS Request ======================= Package Name: ocsinventory Short Description: Open Computer and Software Inventory Next Generation Owners: remi Branches: devel, F-9, F-8, EL-5 InitialCC: Cvsextras Commits: yes cvs done. Package Change Request ====================== Package Name: ocsinventory New Branches: EL-4 cvs done. |