Bug 447285
| Summary: | Review Request: libx86 - library for making real-mode x86 calls | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Garrett <mjg> |
| Component: | Package Review | Assignee: | Adam Jackson <ajax> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jfeeney, notting |
| Target Milestone: | --- | Flags: | ajax:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-05 19:13:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matthew Garrett
2008-05-19 10:25:18 UTC
One obvious bug before I begin, you want %postun , not %postrun . - Package meets naming and packaging guidelines
- Spec file matches base package name.
- Spec has consistent macro usage.
- Meets Packaging Guidelines.
- License
- License field in spec matches
- License file included in package
- Spec in American English
- Spec is legible.
- Sources match upstream md5sum:
41bee1f8e22b82d82b5f7d7ba51abc2a libx86-1.1-1.fc9/libx86-1.1.tar.gz
41bee1f8e22b82d82b5f7d7ba51abc2a libx86-1.1.tar.gz
- Package does not need ExcludeArch
- BuildRequires correct
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Package is code or permissible content.
- Doc subpackage not needed/used.
- Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package compiles and builds on at least one arch.
- Package has no duplicate files in %files.
- Package doesn't own any directories other packages own.
- Package creates no directories.
- No rpmlint output.
Builds in mock locally, submitted to koji but that's being a bit laggy.
The %description text is a bit misleading since you're building it with x86emu
everywhere. Fix that and the %postrun typo and we'll call this approved.
Ok, both fixed. Approved. See http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure for the next steps. New Package CVS Request ======================= Package Name: libx86 Short Description: Library for making real-mode x86 calls Owners: mjg59 Branches: InitialCC: Cvsextras Commits: yes cvs done. Built in rawhide, closing. Package Change Request ====================== Package Name: libx86 New Branches: F-9 cvs done. |