Bug 447406

Summary:	Review Request: libfakekey
Product:	[Fedora] Fedora	Reporter:	jmccann
Component:	Package Review	Assignee:	Matthias Clasen <mclasen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	cschalle, fedora-package-review, jonathan.roberts.uk, katzj, loupgaroublond, mclasen, notting
Target Milestone:	---	Flags:	mclasen: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-05-22 18:25:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jmccann 2008-05-19 20:04:34 UTC

Spec: http://people.fedoraproject.org/~mccann/packages/libfakekey.spec
SRPM: http://people.fedoraproject.org/~mccann/packages/libfakekey-0.1-1.fc9.src.rpm

libfakekey is a dependency of matchbox-keyboard

Comment 1 Matthias Clasen 2008-05-20 01:44:49 UTC

Builds fine in mock

rpmlint output:
libfakekey.i386: W: no-documentation
libfakekey.i386: W: one-line-command-in-%post /sbin/ldconfig
libfakekey.i386: W: one-line-command-in-%postun /sbin/ldconfig
libfakekey-devel.i386: W: no-documentation

You should include COPYING and ChangeLog as %doc files
and do as rpmlint wants you to:

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig


package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: needs to include COPYING
spec language: ok
spec readability: ok
upstream sources: ok
builds: yes
ExcludeArch: n/a
BuildRequires: ok
locale handling: ok
ldconfig: see above
relocatable: n/a
directory ownership: ok
%file duplicates: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: n/a
doc content: ok
headers: ok
static libs: n/a
pkgconfig files: ok
shared libs: ok
-devel package: ok
la files: ok
gui app: n/a
file ownership: ok
%install: ok
utf8 filenames: ok

summary: fix the two issues that rpmlint complained about, then it is fine.

Comment 2 jmccann 2008-05-20 14:07:17 UTC

Ok fixed.  Thanks.

Comment 3 Matthias Clasen 2008-05-20 14:17:33 UTC

Can you point me to the updated spec file, so I can nod it off ?

Comment 4 Matthias Clasen 2008-05-20 14:30:22 UTC

Ok, approved.

Comment 5 jmccann 2008-05-20 15:21:58 UTC

New Package CVS Request
=======================
Package Name: libfakekey
Short Description: Library for converting characters to X key-presses
Owners: mccann
Branches: devel
InitialCC:
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-05-20 16:15:39 UTC

cvs done.

Comment 7 jmccann 2008-05-22 18:25:23 UTC

Built in rawhide.  Thanks.

http://koji.fedoraproject.org/koji/taskinfo?taskID=624886

Comment 8 Parag AN(पराग) 2008-06-18 09:00:15 UTC

*** Bug 451769 has been marked as a duplicate of this bug. ***

Comment 9 Parag AN(पराग) 2008-09-19 04:35:25 UTC

*** Bug 462736 has been marked as a duplicate of this bug. ***