Bug 447429
| Summary: | Review Request: matchbox-keyboard | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | jmccann |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | cschalle, fedora-package-review, katzj, mclasen, notting |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-17 03:53:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
jmccann
2008-05-19 21:30:10 UTC
builds in mock after adding some missing BuildRequires: libpng-devel, libXtst-devel rpmlint output on the built packages: rpmlint /var/lib/mock/fedora-9-i386/result/matchbox-keyboard-0.1-0.2008.05.19.1.fc9.i386.rpm matchbox-keyboard.i386: W: no-documentation matchbox-keyboard.i386: W: one-line-command-in-%post update-desktop-database for docs, should include ChangeLog, COPYING, AUTHORS, README for the update-desktop-database usage, the recommended form is: %post update-desktop-database &> /dev/null ||: %postun update-desktop-database &> /dev/null ||: package name: ok spec file name: ok packaging guidelines: ok, but - should add a hint about where to get the svn snapshot - see the above comment about update-desktop-database - the explicit Requires for libfakekey is unnecessary license: ok license field: ok license file: need to include COPYING spec file language: ok spec file legibility: ok upstream sources: ok buildable: ok ExcludeArch: n/a BuildRequires: need to add libpng-devel and libXtst-devel locale handling: ok ldconfig: ok relocatable: n/a directory ownership: ok duplicate files: ok file permissions: ok %clean: ok macro use: ok permissible content: ok large docs: n%d/a %doc: ok headers: n/a static libs: n/a pkgconfig files: n/a shared libs: n/a devel package: n/a libtool archives: n/a gui app: ok directory ownership: ok %install: ok utf8 filenames: ok Ok, updated now. Thanks. Looks better now, just drop the explicit libfakekey Requires. Automatic library dependencies take care of that already. Ah ok. Updated in place again. Thanks. Ok, approved. New Package CVS Request ======================= Package Name: matchbox-keyboard Short Description: An on screen virtual keyboard Owners: mccann Branches: devel InitialCC: Cvsextras Commits: yes cvs done. It has been built. |