Bug 447566

When I installed this on F9 and tried to compile examples
[parag@localhost Download]$ gcc -Wall -g -o MinimalExample MinimalExample.c -luninum
MinimalExample.c: In function ‘main’:
MinimalExample.c:20: warning: pointer targets in passing argument 2 of
‘StringToInt’ differ in signedness
MinimalExample.c:22: warning: format ‘%u’ expects type ‘unsigned int’, but
argument 2 has type ‘long unsigned int’
[parag@localhost Download]$ ./MinimalExample 
Segmentation fault

GDB gave me
Breakpoint 1, main () at MinimalExample.c:20
20	  StringToInt(&val,str,NS_TYPE_ULONG,NS_ANY);
(gdb) n

Program received signal SIGSEGV, Segmentation fault.
wcStripSeparators (s=0x8048648) at uninum.c:241
241	      *t++ = c;
(gdb) bt
#0  wcStripSeparators (s=0x8048648) at uninum.c:241
#1  0x0011c840 in StringToInt (rvalp=0xbfee1d14, s=0x8048644, ReturnType=0,
NumberSystem=69) at uninum.c:5116
#2  0x08048549 in main () at MinimalExample.c:20
(gdb) 


Am I missing something?

Upstream is looking at the problem, first guess is that problem is in the
example code. The included numconv tools works fine. Continue review?

Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=622193
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5a34c5cf6a6307274dad0ce52b40f94c  libuninum-2.7.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libuninum-2.7-2.fc10 ->
  Provides: libuninum.so.5
  Requires:
 /bin/sh
 libc.so.6
 libc.so.6(GLIBC_2.0)
 libc.so.6(GLIBC_2.1)
 libc.so.6(GLIBC_2.1.3)
 libc.so.6(GLIBC_2.2)
 libc.so.6(GLIBC_2.3)
 libc.so.6(GLIBC_2.3.4)
 libc.so.6(GLIBC_2.4)
 libgmp.so.3
 libuninum.so.5
+ Package libuninum-devel-2.7-2.fc10  ->
  Requires: libuninum = 2.7-2.fc10 libuninum.so.5
+ Not a GUI App.

SHOUDLD:
   Change libuninum rpm group to System Environment/Libraries

APPROVED.

Even example from README is not working. Hope to see upstream will resolve this
issues as early as possible.
for time being I am approving this package.

Things are getting better, examples don't crash anymore, however results are
not correct on x86_64. Upstream is pinged about that. I have removed the
tcl tool from the package.

Updated package:

spec: http://terjeros.fedorapeople.org/libuninum/libuninum.spec
srpm: http://terjeros.fedorapeople.org/libuninum/libuninum-2.7-3.fc9.src.rpm

Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=625953

Please file bugs for x86_64 once package got built and bugzilla gets component
entry libuninum.
Any reason to remove tcl support?

APPROVED.

> Please file bugs for x86_64 once package got built and bugzilla gets component
> entry libuninum.

Ok.

> Any reason to remove tcl support?

Did not seem to work and my focus is as a library for msort.
 
> APPROVED.

Thanks!

New Package CVS Request
=======================
Package Name: libuninum
Short Description: Library for converting unicode strings to numbers
Owners: terjeros
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

cvs done.

Built and pending for testing in bodhi.