Bug 447567
| Summary: | Review Request: msort - Sort files in sophisticated ways | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Terje Røsten <terje.rosten> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-04 21:52:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 447566 | ||
| Bug Blocks: | |||
|
Description
Terje Røsten
2008-05-20 15:17:30 UTC
Note: might split the msg (msort graphical) tool to a msort-gui package. Ok. So msort is GPLv3 and msg is GPLv2. when I start gui from command line, I see that, # msg msg 1.25 Copyright (C) 2005-2008 William J. Poser. This program is free software; you can redistribute it and/or modify it under the terms of version 2 of the GNU General Public License as published by the Free Software Foundation. And then when in gui clicked Help->License its showing GPLv3. This is totally incompatible thing. I guess upstream want gui also to be in GPLv3 but missed to remove license text from top of msg.tcl Can upstream be ping to remove that text from msg.tcl? look http://fedoraproject.org/wiki/Licensing#head-699ce10b1f5d466cd4c3d61301c3651f0c2ca219 > Can upstream be ping to remove that text from msg.tcl?
Yes, done.
New tarball upstream fixing the issue: spec: http://terjeros.fedorapeople.org/msort/msort.spec srpm: http://terjeros.fedorapeople.org/msort/msort-8.46-1.fc9.src.rpm Review: + package builds in mock (rawhide i386). koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=638847 + rpmlint is silent for SRPM andfor RPM. + source files match upstream url aa84730eae0691341919db244f821c68 msort-8.46.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + No desktop file installed. + GUI interface is available. APPROVED. > APPROVED.
Thanks!
New Package CVS Request
=======================
Package Name: msort
Short Description: Sort files in sophisticated ways
Owners: terjeros
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes
cvs done. Built and pushed for F-8, F-9 and rawhide. |