Bug 447599
Summary: | Review Request: immix - image mixer | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicoleau Fabien <nicoleau.fabien> |
Component: | Package Review | Assignee: | Xavier Lamien <lxtnow> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 9 | CC: | fedora-package-review, notting, tjb |
Target Milestone: | --- | Flags: | lxtnow:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.3.2-3.fc9 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-01 01:47:08 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nicoleau Fabien
2008-05-20 18:21:53 UTC
will review this. (Removing NEEDSPONSOR: sponsored by me) Please remember to set the flags properly when you begin a review. Builds with no errors from mock fedora-9-i386, and no output from rpmlint on the installed package. The specfile looks good to me. # Build failed on rawhide : ==> http://koji.fedoraproject.org/koji/taskinfo?taskID=694394 # From desktop file : Application type must be remove from "Icon" entry, you no need to set full path ho craps, type Application must be kept. updated : Spec URL: http://nicoleau.fabien.free.fr/rpms/SPECS/immix.spec SRPM URL: http://nicoleau.fabien.free.fr/rpms/srpms.fc9/immix-1.3.2-3.fc9.src.rpm - rpmlint output : [builder@FEDOBOX tmp]$ rpmlint immix-1.3.2-3.fc9.i386.rpm immix-debuginfo-1.3.2-3.fc9.i386.rpm immix-1.3.2-3.fc9.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. [builder@FEDOBOX tmp]$ - build under mock (fedora-9-i386) is OK - build on rawhide is OK : http://koji.fedoraproject.org/koji/taskinfo?taskID=695213 Changelog : - lrelease-qt4 usage - .desktop file changes OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. BAD license field matches the actual license. OK license is open source-compatible (LGPLv3+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in koji (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. OK Binaries are proper N/A %check is present and all tests pass. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no libtool archives droppings. OK GUI app == Desktop file is present and correct. This package is APPROVED typo : license field is correct -- OK New Package CVS Request ======================= Package Name: immix Short Description: An image mixer Owners: eponyme Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. immix-1.3.2-3.fc8 has been submitted as an update for Fedora 8 immix-1.3.2-3.fc9 has been submitted as an update for Fedora 9 immix-1.3.2-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. immix-1.3.2-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |