Bug 447948
| Summary: | Review Request: R-lmtest - Testing Linear Regression Models for R | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-25 16:31:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Orion Poplawski
2008-05-22 15:54:52 UTC
Builds fine; rpmlint notices that the license tag needs tweaking: finds a bunch of utf8 complaints: W: invalid-license GPL I believe that, according to the COPYRIGHTS file, this is GPLv2 only. rpmlint also complains about a bunch of non-utf8 files: W: file-not-utf8 /usr/lib64/R/library/lmtest/man/lmtest.Rd.gz W: file-not-utf8 /usr/lib64/R/library/lmtest/latex/bondyield.tex and various other tex files. These all seem to come to one name, "Krämer", in 8859-1. I think it's worth converting these, since none of the produced documentation files carry any encoding information. rpmlint also has the two expected complaints about R-make-search-index.sh, which can be ignored. You should probably include the COPYRIGHTS file as %doc. * source files match upstream: 884e9eb00874c4221e50be02e07db10e054241f1466b25017c3f9b296edbd636 lmtest_0.9-21.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field isn't valid. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. X rpmlint has valid complaints. * final provides and requires are sane: lmtest.so()(64bit) R-lmtest = 0.9-1.fc10 = /bin/sh R libR.so()(64bit) libgfortran.so.3()(64bit) * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. Orion, ping? The fixes needed are pretty trivial. Sorry, was on vacation for a while, then busy :-). Spec URL: http://www.cora.nwra.com/~orion/fedora/R-lmtest.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/R-lmtest-0.9-2.fc8.src.rpm * Mon Jun 23 2008 Orion Poplawski <orion.com> 0.9-2 - Fix License, add README and COPYRIGHTS to doc - Fixup non utf8 files Thanks; looks good. APPROVED New Package CVS Request ======================= Package Name: R-lmtest Short Description: Testing Linear Regression Models for R Owners: orion Branches: F-8 F-9 EL-4 EL-5 InitialCC: Cvsextras Commits: yes cvs done. Checked in and built. Thanks all! |