Bug 447954
| Summary: | Review Request: perl-Math-Cephes - Perl interface to the cephes math library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jan.klepek, jdorff, manuel.wolfshant, notting, terje.rosten, vanmeeuwen+fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-01 20:10:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Jeroen van Meeuwen
2008-05-22 16:19:36 UTC
I forgot some pretty stupid things in the .spec New SPEC: http://pilot.genomicscenter.nl/genomics/SPECS/perl-Math-Cephes.spec New SRPM: http://pilot.genomicscenter.nl/genomics/el5/SRPMS/perl-Math-Cephes-0.45-4.el5.src.rpm - starting review - Update with patches for PPC: SPEC: http://pilot.genomicscenter.nl/genomics/SPECS/perl-Math-Cephes.spec SRPM: http://pilot.genomicscenter.nl/genomics/el5/SRPMS/perl-Math-Cephes-0.45-5.el5.src.rpm Ok, so I have a design question. This perl module claims to be an interface to the cephes math library. This library is quite old and not really maintained as seen here: http://www.moshier.net/#Cephes So I wonder if either : - some functions of the Cephes aren't merged in nowadays math library (-lm ?) - If the cephes library could be built separately to be available to other (non-perl) project. (it seems used inside grace and labplot at least) - If the license of the Cephes code is clear enough: http://lists.debian.org/debian-legal/2004/12/msg00295.html Of course, using shared version of the library may prevent some duplicate works in the maintainability of such library, as i expect... It would be interesting to ask to the related project. Unfortunately , theses question already appeared on the ml and i don't see any final conclusion here. So i don't know how is licensed the cephes code source. There are some files in grace (LICENSE.cephes, cephes-license.email) explaining that cephes can be considered GPL. But regarding cephes being built seprately, I think that it would be much better. Still the perl module would need the source to build the swig interface (unless I am wrong), but even in that case we could do a *-source package and reuse it for the swig bindings. Any news from upstream project ? if they could handle a shared version of cephes ? Can you attach the LICENSE.cephes and cephes-license.email, maybe we can block FE-Legal if there is a remaining question. I've not checked yet (/me is on vacation) There are no questions with regard with license, at least no more than for grace. Files are at: http://cvs.fedoraproject.org/viewcvs/rpms/grace/devel/cephes-license.email?rev=1.1&view=auto http://cvs.fedoraproject.org/viewcvs/rpms/grace/devel/LICENSE.cephes?rev=1.1&view=auto Please continue the review as possibly using a shared version of cephes or the math library instead isn't suitable to be addressed in the initial package review. Build Error when tested in mock Fedora 9 i386
(whereas local rpmbuild worked).
This might be caused by a parallel make problem as the libmd.a is created after
this linking error.
---------------
builddir/build/BUILD/Math-Cephes-0.45/libmd/libmd.a: file not recognized: File
truncated
collect2: ld returned 1 exit status
---------------
Just remove %{?_smp_mflags} and add a note.
For the same version, arch: I also have lot of:
-------------
Cephes_wrap.c: In function '_wrap_cmplx_r_set':
Cephes_wrap.c:1326: warning: null argument where non-null required (argument 1)
-------------
New Spec: http://www.kanarip.com/custom/SPECS/perl-Math-Cephes.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/perl-Math-Cephes-0.45-7.fc10.src.rpm Did a few scratch builds just for kicks: - f8: http://koji.fedoraproject.org/koji/taskinfo?taskID=781647 - f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=781652 - f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=781657 I cannot review this. Actually I'm facing the same problem with perl-EV (#448613) And I'm not strong enough in perl to enforce the request of having libraries built shared. any update? there is new version of perl-math-cephes in cpan I consider a shared cephes library nice to have, but not a blocker. The library is for math functions which are > 200 years old, there should not be a need to update this software every year. Import the package and open a ticket against perl-Math-Cephes with a shared libs request, add info about grace and labplot. If no one objects on this point I will do the review. Any way, please update to latest release. Hi Jeroen, could you please update to latest release Math-Cephes-0.47: http://search.cpan.org/dist/Math-Cephes/ Jeroen, are you still interested in this package ? If so, please update the spec to use the most recent release of Math-Cephes and, unless Terje wants to do it, I'll try to do the review. It's been a few months since the last comment, and over two years and several questions with no response from the submitter. I'm just going to close this. |