Bug 448145

Summary: NFS4 mounts deleted from fstab during upgrade
Product: [Fedora] Fedora Reporter: Jeff Garzik <jgarzik>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: medium    
Version: 9CC: drkludge, peterm, rolf
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-06-21 20:28:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jeff Garzik 2008-05-23 18:55:14 UTC
Description of problem:
Upgrading from Fedora 8/x86-64 to Fedora 9/x86-64 using preupgrade-cli. 
Everything upgraded properly as expected, save for one thing:

The newly-upgraded machine's fstab was missing the NFS mounts manually placed
there, leading to users with NFS-mounted drives unable to login after the upgrade.

Version-Release number of selected component (if applicable):
Whatever preupgrade-cli installed on 2008-05-22 for Fedora 9 target.

How reproducible:
100%

Steps to Reproduce:
1. Install Fedora 8.
2. Manually add NFSv4 mount entry to /etc/fstab
3. Verify that mount works
4. Run pre-upgrade-cli, upgrading to Fedora 9
5. Reboot
6. Complete installation, via anaconda
7. Reboot
8. Note that no NFS filesystems are mounted, and no NFS entries are in /etc/fstab
  
Actual results:
No NFS mounts.

Expected results:
NFS settings carried through upgrade.

Additional info:

Comment 1 Greg Morgan 2008-05-26 05:59:38 UTC
fsset.py takes care of fstab edits.  I am guessing that preupdate is not passing
the correct rootPath to edit fstab similar to how a system is mounted during
upgrade or installation i.e. path = anaconda.rootPath + '/etc/fstab'.  Hence,
the fstab is not correctly read to copy the existing mount points to the new
system.  The only other problem could be that lines are dropped from your fstab
because they are not properly formatted i.e.   if len(fields) < 4: continue
..elif len(fields) > 6:continue.

Perhaps submitting your fstab nsf mounts may be helpful?

It looks like this should go to the preupdate folks so they can determine if a
patch is required for anaconda or a fix in their code.  However, I don't have
permission to change this yet.


Comment 2 Jeff Garzik 2008-05-26 21:37:55 UTC
Sure thing.  All the machines in my home lab have the following in /etc/fstab as
the last line of the file:

pretzel:/               /g                      nfs4    defaults 0 0

The rest of fstab contents is stock Fedora-via-anaconda.

Comment 3 Jeremy Katz 2008-05-27 15:36:18 UTC
nfs4 is the key here.  But should be fixed in git.

Comment 4 Chris Lumens 2008-08-06 19:15:55 UTC
*** Bug 418641 has been marked as a duplicate of this bug. ***