Bug 448249
| Summary: | Review Request: lxsplit - File split / merge utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rahul Sundaram <sundaram> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, smohan |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | panemade:
fedora-review+
tcallawa: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-28 01:51:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rahul Sundaram
2008-05-25 00:22:16 UTC
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=627472 do you want to use dist tag also? Sure. Added dist tag http://sundaram.fedorapeople.org/packages/lxsplit.spec http://sundaram.fedorapeople.org/packages/lxsplit-0.2.2-2.fc9.src.rpm I see that compiler flags are not honoured. Use following
%{__make} CFLAGS="$RPM_OPT_FLAGS" %{?_smp_flags}
also,change
%defattr(-,root,root)
to
%defattr(-,root,root,-)
COPYING is missing from %doc
What does this tool do what split (from coreutils) doesn't? Ralf, From http://lxsplit.sourceforge.net, lxSplit splits and merges files with the -s and -j flags respectively. Starting with version 0.2.1, lxSplit can handle large files (>= 4 GB) both when splitting and joining. I am not sure whether split can handle >= 4GB files. also, do you know any command that will join fixed size pieces created using "split" command? "split" is "cat"'s brother. Both are ISO/POSIX/IEEE standardized tools and are supposed to be available on any POSIX-compliant OS. On Linux (and thus Fedora), they are part of coreutils I don't know about these tools current limitations on file sizes. Theoretically these should be arbitrary large and only be limited by OS details. Ralf, Can you provide me link of any guidelines or policy page that says that new similar kind of functionality packages ( compared to existing packages in Fedora) should not be accepted? So that I will proceed with closing this review with appropriate official reference link here. I don't see any problem in accepting this package in fedora. (In reply to comment #8) > I don't see any problem in accepting this package in fedora. I didn't mean to say this package shall be rejected. All I am saying is that there technically is hardly any need for anybody to use this tool on modern OSes. I.e. I am questioning upstream. From upstream: --- Short answer: it actually doesn't. Long answer: lxsplit isn't as flexible and as weird for the split file name and suffix usage as split is, it always appends .001 (up to .999) to the filename and expects the same pattern when joining files: easier for users and it is the same behaviour for hjsplit. It also makes sure that no files are missing between *.001 and the last one when joining, and only strips the .<number> from the input file for the output filename. Less cmdline arguments. This util is for people who don't know about split / cat and only want to do a quick large file splitting / joining. And yes, if it want a gui app, which I intend to do, it would be more useful. --- My important consideration was a compatible equivalent to hjsplit which is a popular utility in Windows. Fixed issues cited in review: http://sundaram.fedorapeople.org/packages/lxsplit.spec http://sundaram.fedorapeople.org/packages/lxsplit-0.2.2-3.fc9.src.rpm Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=630038 + rpmlint is silent for SRPM and RPM. + source files match upstream. f8de6f2d70b31eb473fbe2831844da77 lxsplit-0.2.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: lxsplit Short Description: File split / merge utility Owners: sundaram Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes Add these branches too: New Branches: EL-4 EL-5 Just fixing flags... cvs done builds done Rahul, This is the second time you removed fedora-review+ from my review to fedora-review? Make sure this will not happen again in future. Ok done. |