Bug 448531
| Summary: | Review Request: pyrenamer - A mass file renamer written in PyGTK | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jean-François Martin <lokthare> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.5.0-4.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-13 02:22:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jean-François Martin
2008-05-27 14:01:47 UTC
*** Bug 340011 has been marked as a duplicate of this bug. *** Do you in need of a sponsor? By the way your package does not build on dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=630509 No, i don't to be sponsored (cvsextras approved) Spec URL: http://lokthare.fedorapeople.org/temp/pyrenamer.spec SRPM URL: http://lokthare.fedorapeople.org/temp/pyrenamer-0.5.0-2.fc9.src.rpm * Fix BR: Add perl(XML::Parser). For 0.5.0-2
* BuildRequires
- "python-eyed3" seems needed also for BuildRequires.
! build.log shows (from following)
http://koji.fedoraproject.org/koji/taskinfo?taskID=632906
--------------------------------------------------------
177 checking for eyeD3 module...
178 no
179 configure: WARNING: eyeD3 not found, rename music disabled!
--------------------------------------------------------
This affects HAVE_EYED3 macro in configure{,.ac} then
src/pyrenamer_globals.py.in. Actually the installed
pyrenamer/pyrenamer_globals.py has:
--------------------------------------------------------
26 have_eyed3=False
--------------------------------------------------------
* spec file convention
- Please write in the order:
--------------------------------------------------------
%prep
%build
%install
%clean
%pre (%post, etc)
%files
--------------------------------------------------------
i.e. Please don't write scriptlets between %prep and %build
so that we can read your spec file easily.
Spec URL: http://lokthare.fedorapeople.org/temp/pyrenamer.spec SRPM URL: http://lokthare.fedorapeople.org/temp/pyrenamer-0.5.0-3.fc9.src.rpm - Fix BR: Add python-eyed3 - Reorder to match spec file convention Okay, perhaps this is the final check. For 0.5.0-3: * python module dependency ---------------------------------------------------------- # grep -h 'import ' `rpm -ql pyrenamer 2>/dev/null | grep -v /usr/shre/doc` | sed -e 's|^[ \t][ \t]*||' | sort | uniq from gettext import gettext as _ from gettext import gettext as _ from os import path as ospath from os.path import isfile from pyrenamer import pyrenamer from pyrenamer import treefilebrowser import EXIF import TreeViewTooltips as tvt import dircache import eyeD3 import gconf import getopt import gettext import glob import gobject import gtk import gtk.gdk import gtk.glade import locale import os import pygtk import pyrenamer_globals import pyrenamer_globals as pyrenamerglob import pyrenamerfilefuncs as renamerfilefuncs import re import sys import threading import time import tooltips import treefilebrowser import user import warnings import webbrowser ---------------------------------------------------------- - It seems the following is missing from Requires (please check!!) ---------------------------------------------------------- gnome-python2-gconf pygtk2-libglade ---------------------------------------------------------- Spec URL: http://lokthare.fedorapeople.org/temp/pyrenamer.spec SRPM URL: http://lokthare.fedorapeople.org/temp/pyrenamer-0.5.0-4.fc9.src.rpm - Fix Requires : Add gnome-python2-gconf and pygtk2-libglade Okay. -------------------------------------------------------- This package (pyrenamer) is APPROVED by me -------------------------------------------------------- Please follow http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess from step 7. New Package CVS Request ======================= Package Name: pyrenamer Short Description: A mass file renamer written in PyGTK Owners: lokthare Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. pyrenamer-0.5.0-4.fc9 has been submitted as an update for Fedora 9 pyrenamer-0.5.0-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |