Bug 448558
| Summary: | Review Request: xorg-x11-drv-sunbw2 - sunbw2 x.org driver | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bdpepple:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-06 21:44:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dennis Gilmore
2008-05-27 17:12:07 UTC
Good:
* Verified source tarball against git.
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
Bad:
* rpmlint produces the following error:
xorg-x11-drv-sunbw2.sparc64: W: invalid-license MIT/X11
Looking at the license matrix, it looks like it should just be MIT. You can fix
this when you import this into CVS.
Note: I don't have the hardware to verify that this driver works, but from a
packaging standpoint this package looks fine.
+1 APPROVE
Package Name: xorg-x11-drv-sunbw2 Short Description: X driver for sunbw2 Owners: ausil spot jima pjones Branches: F-9 InitialCC: Cvsextras Commits: yes imported and built thanks for the review |