Bug 448582

Summary: Review Request: automoc - KDE4 Automoc
Product: [Fedora] Fedora Reporter: Lorenzo Villani <lorenzo>
Component: Package ReviewAssignee: Steven M. Parrish <tuxbrewr>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, rdieter, tuxbrewr
Target Milestone: ---Flags: tuxbrewr: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-06-01 11:04:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Steven M. Parrish 2008-05-28 16:15:59 UTC
RPM passed rpmlint however would not build on X86_64 for F9  see build log here
http://koji.fedoraproject.org/koji/getfile?taskID=633421&name=build.log

Same for PPC64
http://koji.fedoraproject.org/koji/getfile?taskID=633456&name=build.log

Looks like an issue with {_libdir}

Comment 2 Rex Dieter 2008-05-28 16:24:04 UTC
Yep, CMakeLists.txt hard-codes
DESTINATION lib/automoc4

Comment 3 Rex Dieter 2008-05-28 16:27:45 UTC
scratch build with quick-n-dirty patch:
http://koji.fedoraproject.org/koji/taskinfo?taskID=633479

See also:
http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/automoc/

Comment 4 Lorenzo Villani 2008-05-28 21:46:17 UTC
Spec URL: http://rpm.binaryhelix.org/SPECS/kde/automoc.spec
SRPM URL:
http://rpm.binaryhelix.org/SRPMS/automoc-1.0-0.2.20080527svn811390.fc9.src.rpm

* Wed May 28 2008 Lorenzo Villani <lvillani> -
1.0-0.2.20080527svn811390
- Patched to make it build on other systems than i386 (thanks to Rex Dieter)



Comment 5 Rex Dieter 2008-05-28 22:47:11 UTC
Should also:
Requires: cmake
to account for ownership of:
%{_datadir}/cmake/Modules


Comment 6 Lorenzo Villani 2008-05-29 11:05:06 UTC
Spec URL: http://rpm.binaryhelix.org/SPECS/kde/automoc.spec
SRPM URL:
http://rpm.binaryhelix.org/SRPMS/automoc-1.0-0.3.20080527svn811390.fc9.src.rpm

* Thu May 29 2008 Lorenzo Villani <lvillani> -
1.0-0.3.20080527svn811390
- Added 'cmake' to Requires



Comment 7 Steven M. Parrish 2008-05-29 21:34:16 UTC
rpmlint still likes it.  I dont see any other issues.

Comment 8 Steven M. Parrish 2008-05-29 21:35:07 UTC
Approved

Comment 9 Lorenzo Villani 2008-05-30 09:08:50 UTC
New Package CVS Request
=======================
Package Name: automoc
Short Description: KDE4 Automoc
Owners: arbiter,rdieter,kkofler,tuxbrewr
Branches: F-8 F-9
InitialCC:
Cvsextras Commits:


Comment 10 Lorenzo Villani 2008-05-30 09:19:51 UTC
New Package CVS Request
=======================
Package Name: automoc
Short Description: KDE4 Automoc
Owners: arbiter,rdieter,kkofler,tuxbrewr
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


Comment 11 Kevin Fenzi 2008-05-30 20:16:15 UTC
cvs done.