Bug 448606
| Summary: | Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Sourada <martin.sourada> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bdpepple:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-31 12:13:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Martin Sourada
2008-05-27 19:59:12 UTC
Couple of quick notes: 1. Your gtk icon cache scriptlets don't follow the guidelines. Refer to: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache 2. Looks like the configure file requires a run time gstreamer plugin to build. Refer to: http://koji.fedoraproject.org/koji/getfile?taskID=631159&name=build.log (In reply to comment #1) > Couple of quick notes: > 1. Your gtk icon cache scriptlets don't follow the guidelines. Refer to: > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache Aah, didn't noticed there was such a guideline (it wasn't around about a year ago or so, was it?). Fixed. > 2. Looks like the configure file requires a run time gstreamer plugin to build. > Refer to: http://koji.fedoraproject.org/koji/getfile?taskID=631159&name=build.log Yup, it needs gstreamer-plugins-good. I overlooked it bacause it needs only the runtime package... SPEC: http://mso.fedorapeople.org/packages/SPECS/subtitleeditor.spec SRPM: http://mso.fedorapeople.org/packages/SRPMS/subtitleeditor-0.21.1-2.fc9.src.rpm MD5Sum:
1cd4433c3ccdbc770fa4c91b1e95697a subtitleeditor-0.21.1.tar.gz
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint does not find problems
* Package installs and uninstalls cleanly
Minor (non-blocker):
* Might want to consider building w/ unit testing.
+1 APPROVED.
(In reply to comment #3) > Minor (non-blocker): > * Might want to consider building w/ unit testing. Done. SPEC: http://mso.fedorapeople.org/packages/SPECS/subtitleeditor.spec SRPM: http://mso.fedorapeople.org/packages/SRPMS/subtitleeditor-0.21.1-3.fc9.src.rpm New Package CVS Request ======================= Package Name: subtitleeditor Short Description: GTK+2 tool to edit subtitles for GNU/Linux/*BSD Owners: mso Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. subtitleeditor-0.21.1-3.fc9 has been submitted as an update for Fedora 9 subtitleeditor-0.21.1-3.fc8 has been submitted as an update for Fedora 8 subtitleeditor-0.21.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. subtitleeditor-0.21.1-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. subtitleeditor-0.21.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |