Bug 448650

Kevin & Rex.  This is just the straight package.  No changes to the gmm-config
script yet.  Will work on that in tomorrow.  Just wanted to get this out there
since I know part of kdeedu depend on it.

Steven

You should leave the main package empty and put everything into %package devel 
like eigen is doing.

This is inconsistent:
...
./configure --prefix=/usr
...
%files
%{_includedir}/gmm/

Please use %configure instead of "./configure ..." such %{_includedir} gets
propagated to the package's guts.

Done and done. 

Any particular reason to call this package gmm++?

The upstream tarball is called gmm, which according to Fedora conventions, would
mean the package must be called "gmm" and not "gmm++".

gmm++ is the official project name, as such it falls within the Fedora naming
scheme.

Ralf's sentiments are right on, and including the ++'s need to be justified.  To
that end, 
1.  I concur with Steven that upstream indeed does call it gmm++ everywhere on
it's upstream website.  Tho, makes one wonder why the tarball name is different.
2.  Using just gmm could lead to confusion, e.g. with
http://www.datalab.uci.edu/resources/gmm/  ??

(In reply to comment #7)
> 1.  I concur with Steven that upstream indeed does call it gmm++ everywhere on
> it's upstream website.
Not quite. They call it "Gmm++" on their website.

Heh, ok, would you prefer Gmm++ ?  (I don't think anyone would). :)

(In reply to comment #9)
> Heh, ok, would you prefer Gmm++ ?  (I don't think anyone would). :)
I would prefer this package to be called "gmm", because that's what the FPG
mandates it to be named (after the tarball).

Besides this, yes, I'd prefer "Gmm++" over "gmm++", because size - pardon - case
matters: Coke is something different than coke.

OK, let's go with gmm (it is friendlier, after-all).  That said, please add to
-devel:
Provides: gmm++-devel = %{version}-%{release}
and we'll proceed from there.

I took the liberty of making said change, and issued a scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=633206

fwiw,
http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/gmm/gmm.spec
http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/gmm/gmm-3.0-2.src.rpm

rpmlint *.rpm
gmm.src:26: W: setup-not-quiet
gmm.src: W: invalid-license GPLv2.1+
gmm-devel.noarch: W: no-documentation
gmm-devel.noarch: W: invalid-license GPLv2.1+

item 1; MUST fix license tag,
License: LGPLv2+

item 2: SHOULD use -q flag on %setup

The rest of the contents are just headers, in their own folder/namespace, simple
and harmless.

Source verified:
e543571d8812357374699491014abd58  gmm-3.0.tar.gz

naming: ok (hopefully now)
scriptlets: n/a
macros: ok

APPROVED.

(fixing the items above are mostly trivial, I'll trust you'll do that before
building).

New Package CVS Request
=======================
Package Name: gmm
Short Description: C++ library for sparse, dense and skyline matrices
Owners: tuxbrewr
Branches: F-8 F-9
InitialCC: rdieter
Cvsextras Commits: yes

cvs done.

gmm-3.0-3.fc8 has been submitted as an update for Fedora 8

gmm-3.0-3.fc9 has been submitted as an update for Fedora 9

gmm-3.0-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

gmm-3.0-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.