Bug 448702

Summary: Review Request: SndObj - The Sound Object Library
Product: [Fedora] Fedora Reporter: Victor Lazzarini <victor.lazzarini>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DEFERRED QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, mtasaka, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-09-10 07:02:04 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    
Attachments:
Description Flags
patch to address cstring issues none

Description Victor Lazzarini 2008-05-28 06:56:51 EDT
Spec URL: http://music.nuim.ie/vlazzarini/tmp/SndObj.spec
SRPM URL: http://music.nuim.ie/vlazzarini/tmp/SndObj-2.6.6-0.fc7.src.rpm
Description: This the package of the SndObj library, a general-purpose 
audio programming library. This is my second package and I would like
it to be reviewed as part of the process of my getting sponsored.
Comment 1 Mamoru TASAKA 2008-05-28 11:08:31 EDT
For what branches (i.e. Fedora-[10-8] or olpc) do you want to
import this package?
Comment 2 Victor Lazzarini 2008-05-28 11:37:29 EDT
If possible, both; otherwise just Fedora
Comment 3 Mamoru TASAKA 2008-05-28 14:09:26 EDT
Well, your srpm does not build on either dist-f10 or dist-f9-updates-candidate:

http://koji.fedoraproject.org/koji/taskinfo?taskID=633523
http://koji.fedoraproject.org/koji/taskinfo?taskID=633567

Unfortunately I am not scons expert and perhaps I don't know
what is going on.
Comment 4 Victor Lazzarini 2008-05-28 14:28:13 EDT
It's OK, I can see what the problem is, there is a Command
target that scons does not like. I'll fix this tomorrow.
Thanks. 
Comment 5 Victor Lazzarini 2008-05-29 12:51:45 EDT
I think I have the scons problem fixed now. Here are the
new packages
Spec URL: http://music.nuim.ie/vlazzarini/tmp/SndObj.spec
SRPM URL: http://music.nuim.ie/vlazzarini/tmp/SndObj-2.6.6-1.fc7.src.rpm

Thanks
Comment 6 Mamoru TASAKA 2008-05-29 13:14:38 EDT
This time build fails with another reason (perhaps gcc43 header files
inclusion change)

http://koji.fedoraproject.org/koji/taskinfo?taskID=635118
Comment 7 Victor Lazzarini 2008-05-29 14:25:45 EDT
OK. Do you know where memset() is in gcc43? This seems easy to
fix.
Thanks 
Comment 8 Ralf Corsepius 2008-05-29 21:49:52 EDT
(In reply to comment #7)
> OK. Do you know where memset() is in gcc43?
man memset
... #include <string.h>
=> #include <cstring>
Comment 9 Ralf Corsepius 2008-05-29 21:52:02 EDT
Created attachment 307156 [details]
patch to address cstring issues
Comment 10 Mamoru TASAKA 2008-05-30 07:17:09 EDT
Removing NEEDSPONSOR, I am sponsoring
Comment 11 Mamoru TASAKA 2008-06-06 11:15:06 EDT
Ralf, thank you for the patch.

Well, even after applying the patch in comment 9, the build still fails
(due to another reason)
http://koji.fedoraproject.org/koji/taskinfo?taskID=650441
Comment 12 Jason Tibbitts 2008-06-28 13:23:44 EDT
Any response, Victor?  It's been a month since your last comment.
Comment 13 Victor Lazzarini 2008-06-28 14:04:39 EDT
Sorry, but I have not had time to work on this. I have fixes for
everything and now I can test it on Koji. But it will be mid-July
before I can get around to doing it. 
I am taking this off the urgent priority.
Comment 14 Victor Lazzarini 2008-06-28 14:04:48 EDT
Sorry, but I have not had time to work on this. I have fixes for
everything and now I can test it on Koji. But it will be mid-July
before I can get around to doing it. 
I am taking this off the urgent priority.
Comment 15 Jason Tibbitts 2008-06-28 15:42:09 EDT
OK, just clear the status whiteboard when you're ready and this will reappear in
the review queue.
Comment 16 Mamoru TASAKA 2008-07-24 13:18:08 EDT
What is the status of this package?
Comment 17 Victor Lazzarini 2008-07-24 13:50:46 EDT
Not ready for re-review yet. I have to fix some of the scons build issues
before I set it for approval. 
Comment 18 Mamoru TASAKA 2008-09-10 03:26:11 EDT
Any updates here?
Comment 19 Victor Lazzarini 2008-09-10 07:02:04 EDT
I have closed this bug for the moment. The package needs some extra work that will  take a little longer than I predicted. I will open a new ticket when I have it ready for review again.
Comment 20 Mamoru TASAKA 2008-09-10 07:50:17 EDT
Okay, feel free to open a new review request when it is ready.