Bug 448748

Wanna swap reviews? :

* elice - Elice is a PureBasic to c++ translator / compiler
https://bugzilla.redhat.com/show_bug.cgi?id=448310

* lostlabyrinth - Lost Labyrinth is a coffeebreak dungeon crawling game
https://bugzilla.redhat.com/show_bug.cgi?id=448311

* lostlabyrinth-sounds - Lost Labyrinth sounds
https://bugzilla.redhat.com/show_bug.cgi?id=448312

* lostlabyrinth-graphics - Lost Labyrinth graphics
https://bugzilla.redhat.com/show_bug.cgi?id=448313

* trophy - Car racing game with special features
https://bugzilla.redhat.com/show_bug.cgi?id=448422

Full review done, must fix:

* You don't BuildRequire anything you need at least allegro-devel

* Currently you copy everything to %{_datadir} and then remove what you don't
  need, thats really the wrong way around, esp you mostly need to copy a few dirs.

* crashes on x86_64 (I'll investigate this and see if I can come up with a fix)

More must fix:

* Remove bogus ChangeLog INSTALL NEWS README files from %doc, they are all
  useless.

OKay, I now have it working on x86_64, and with these it should work on ppc too,
I've already submitted these patches upstream.

cylindrix-1.0-fix-packing.patch:
 Change #ifdef so that packing of applicable structures gets enabled,
 remove PACKED_STRUCT macro from struct members which have 1 byte alignment
 by default to shut up warnings. This fixes playback of the cylindrix logo fli
 on startup

cylindrix-1.0-arch-independ-file-read.patch:
 reading a memory dump of a struct from disk, will only work on the same
 machine as the struct was created, replace the simple fread(struct) calls
 with code which knows the data on disk is an intel struct dump and reads it
 in such a way it will work on any platform

cylindrix-1.0-use-int-not-long.patch:
 cylindrix uses longs all over the place in the sourcecode where it wants
 32 bits integers, however longs are 64 bit on 64 bit machines wrecking havoc,
 this patch replaces all use of long with int.


Note,

Even with these we are still not good to go, I need to also make the writing of
the overal stats system independent and currently saving any settings / stats
will not work at all when run as user, because you are starting cylindrix under
/usr/share/cylindrix where it cannot write its settings.

Instead from the script you should create a ~/.cylindrix, symlink the relevant
data dirs under there, and copy the config / pilot files, so that they can be
overridden and then start cylindrix-bin under ~/.cylindrix.

I'll be waiting for a new version from you to review with all the mentioned Must
FIX items fixed, these patches applied and the startup script modified so that
settings cna be saved.

Once that is done I'll start working on making the overal stat saving platform
agnostic.

Created attachment 309415 [details]
cylindrix-1.0-fix-packing.patch

Created attachment 309416 [details]
cylindrix-1.0-arch-independ-file-read.patch

Created attachment 309417 [details]
cylindrix-1.0-use-int-not-long.patch

All the above addressed.  Thanks for the massive amount of work!

SRPM: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix-1.0-2.fc9.src.rpm
SPEC: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix.spec

Much better, but still needs a tiny bit of work:

MUST FIX
--------

* Don't install cylindrix.rc, cylindrix.dsp and cylindrix.ico, those are visual
  studio project files
* When an icon is installed in the fdo icon hierarchy it should be named without
  extension in the .desktop file
* Apply one more patch to fix writing of overal stats on non i386 machines
  (I'll start working on this now, so don't expect it to be attached
   immediately).

SHOULD FIX
----------

* Change: 'make CFLAGS="$RPM_OPT_FLAGS"' to
  'make CFLAGS="$RPM_OPT_FLAGS -Wno-pointer-sign"'

  This way only the usefull warnings remain.

Corrected VS files, icon extension, cflags.

SRPM: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix-1.0-3.fc9.src.rpm
SPEC: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix.spec

Created attachment 309525 [details]
cylindrix-1.0-arch-independ-file-write.patch

More MUST FIX:
--------------

* The "if [ ! -a ~/.cylindrix ]; then" line in cylindrix.sh should be
  if [ ! -d ~/.cylindrix ]; then
  Now it tries to create all the symlinks each time flooding the terminal
  with errors

* gamedata should be copied and not symlinked, as it contains various files
  which are written

More should fix:
----------------

* It would be better to at the end of cylindrix.sh, not use:
  'cylindrix-bin' but instead use:
  exec cylindrix-bin "$@"

  The exec stops from a useless sh process hanging around and the "$@" passes
  any options passed to the script to the executable.

Created attachment 309526 [details]
cylindrix-1.0-arch-independ-file-write.patch

New version, which does not mess up the displaying of the filenames in the
menu, please use this version.

All addressed, with new patch.

SRPM: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix-1.0-4.fc9.src.rpm
SPEC: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix.spec

Perfect: approved!

New Package CVS Request
=======================
Package Name: cylindrix
Short Description: 3 degrees of freedom combat game
Owners: limb
Branches: devel F-9 F-8
InitialCC:
Cvsextras Commits: yes

Thanks!

CVS Done

cylindrix-1.0-4.fc9 has been submitted as an update for Fedora 9

cylindrix-1.0-4.fc8 has been submitted as an update for Fedora 8

Imported, built, updates submitted.  Thanks!

cylindrix-1.0-4.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

cylindrix-1.0-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

cylindrix-1.0-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.