Bug 449031
| Summary: | spec templates should use %{buildroot} instead of $RPM_BUILD_ROOT | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kyle VanderBeek <kylev> |
| Component: | rpmdevtools | Assignee: | Ville Skyttä <ville.skytta> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 8 | CC: | rdieter, rickyz |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugzilla.redhat.com/show_bug.cgi?id=445028 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-30 18:47:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
fwiw, current fedora packaging guidelines allow either style to be used as
long as it is used consistently, ie, no mixing of %{buildroot} and
$RPM_BUILD_ROOT
Closing since it seems rickyz's advice was not in accordance with packaging standards. https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS BTW "rpmdev-newspec -m" emits templates that use the macro style. (In reply to comment #2) > Closing since it seems rickyz's advice was not in accordance with packaging > standards. I'm sorry, but I'm pretty sure that my advice was correct. My exact words were "Be completely consistent with your macros and use %{buildroot} instead of $RPM_BUILD_ROOT." As you can see, I did not recommend one style over another, I just said to be consistent, as the guidelines suggest: "Mixing the two styles, while valid, is bad from a QA and usability point of view, and should not be done in Fedora packages." |
Description of problem: Generated .spec templates use $RPM_BUILD_ROOT instead of the more modern %{buildroot}. Version-Release number of selected component (if applicable): 6.4-1.fc8 How reproducible: Always Steps to Reproduce: 1. rpmdev-newspec -t python foo 2. Examine resulting foo.spec and see RPM_BUILD_ROOT at least 3 times. Actual results: Use $RPM_BUILD_ROOT . Expected results: Should use %{buildroot} . Additional info: In this package review: https://bugzilla.redhat.com/show_bug.cgi?id=445028 rickyz recommends I use the %{} style of macro for the build root so we don't have any of the older shell-style variables. If that's the way we want things to be, we should update all of the templates to reflect that.