Bug 449067
| Summary: | Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Catalyst-Plugin-Session/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-30 21:14:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Weyl
2008-05-30 07:07:12 UTC
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=635914 + rpmlint is silent for SRPM and for RPM. + source files match upstream url eb7e9679234cd4f4269b5b1869141082 Catalyst-Plugin-Session-0.19.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful, 3 tests skipped. Files=8, Tests=33, 1 wallclock secs ( 1.01 cusr + 0.07 csys = 1.08 CPU) + package perl-Catalyst-Plugin-Session-0.19-1.fc9 => Provides: perl(Catalyst::Plugin::Session) = 0.19 perl(Catalyst::Plugin::Session::State) perl(Catalyst::Plugin::Session::Store) perl(Catalyst::Plugin::Session::Store::Dummy) perl(Catalyst::Plugin::Session::Test::Store) perl(Catalyst::Plugin::SessionStateTest) Requires: perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Catalyst) perl(Catalyst::Exception) perl(Catalyst::Test) perl(Digest) perl(File::Spec) perl(File::Temp) perl(NEXT) perl(Object::Signature) perl(Test::More) perl(base) perl(overload) perl(strict) perl(utf8) perl(warnings) I don't know why some tests got skipped all skipped: Catalyst::Plugin::Session::State::Cookie version 0.03 or higher is required for this test See build.log Including ::Cookie as a BR would create a circular buildloop, as ::Cookie has ::Session as a mandatory BR. (In reply to comment #3) > Including ::Cookie as a BR would create a circular buildloop, as ::Cookie has > ::Session as a mandatory BR. OK. APPROVED. New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-Session Short Description: Catalyst generic session plugin Owners: cweyl Branches: F-7, F-8, F-9, devel InitialCC: perl-sig cvs done (except for F-7, as we are no longer doing F-7 branches). Imported and built for rawhide. Thanks for the review! :) Package Change Request ====================== Package Name: perl-Catalyst-Plugin-Session New Branches: el6 Owners: iarnell Chris doesn't maintain his packages in EPEL, but doesn't have a problem with others doing so. Git done (by process-git-requests). |