Bug 449840

I'll pick up this review, I believe you need to depend on
python-setuptools-devel now (per
http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_using_Setuptools)
for F9+

Ricky's python-dictclient spec file recently passed review w/ it doing this way
(http://cvs.fedoraproject.org/viewcvs/rpms/python-dictclient/F-8/python-dictclient.spec?rev=1.1&view=markup)
as an example.

Full review coming up.

Okay, everything was happy without the Providing Eggs using Setuptools bit, so
I'm happy, I think that's something on the 'would be nice' list though. :)

MUST:
Y: rpmlint on each package
Y: Meets Package Naming Guidelines
Y: Spec file name matches base package name
Y: License field is valid
Y: Meets Packaging Guidelines
 -: License included in package (if included in source)
 Y: Spec file written in en_US
 Y: Spec file is legible
 Y: Sources match upstream source
 Y: Source URL 'sane'
 Y: Compiles successfully - [F9 (noarch)]
 -: ExcludeArch required?
 Y: All Build Dependencies Listed
 -: Handles locales sanely
 -: Library packages run ldconfig
 Y: Package is not relocatable
 -: Package owns all directories created
 Y: No duplicate file listings
 Y: defattr set correctly
 Y: %clean is used
 Y: Macro use conisistant
 Y: Contains Code/Content that is allowed
 -: Large Documentation in -doc subpackage
 Y: %doc must not affect package runtime
 -: Header files in -devel
 -: Static libraries in -static
 -: pkgconfig files require pkgconfig
 -: Library files are located in correct package
 -: -devel requires base package w/ fully versioned dependency
 -: Packages do not contact .la (libtool) archives
 -: GUI Apps have .desktop files
 Y: No duplicate directory ownerships
 Y: %install cleans buildroot
 Y: Filenames are valid UTF-8

SHOULD:
-: Description/Summary sections contain translations
-: Builds in mock/koji
Y: Builds on all architectures
-: Scriptlets are sane
-: Subpackages require base package
-: pkgconfig.pc files in -devel
-: File dependencies should only be in /etc /bin /sbin /usr/bin /usr/sbin

Only issues to me is:

No copying file, the source points to http://trac.edgewall.org/wiki/TracLicense
which is all fine and dandy, but it'd be nice to ask Upstream to include it in
SVN sometime :)

Here's your APPROVED ticket, please take it to the next counter (CVS).

After investigation, it is no longer necessary to pull in
python-setuptools-devel.  That's only necessary if you want the command line
executed easy_install, which we do not need since we're using python setup.py
and setuptools directly.

New Package CVS Request
=======================
Package Name: trac-spamfilter-plugin
Short Description: Spam-Filter plugin for Trac
Owners: jkeating
Branches: EL-5
InitialCC:
Cvsextras Commits: yes

cvs done.

Do we still need this bug open?

I think this bug can be closed now.

By the way, would you like a co-maintainer? I just rolled myself a package based on svn revision 8330, which fixes 5 upstream bugs (#6130, #7627, #8032, #8121, #8257 - http://trac.edgewall.org/ticket/8257 seems particularly relevant) and is worth updating to IMHO. I'd be happy to make the update in Fedora too.

Sorry, yes it can be closed.

Paul, I'd love a co-maintainer.  Please apply in pkgdb and I'll approve you.