Bug 449869 (tasque)

Some random comments on 0.1.5-1:

* Version
  - Current newest tarball seems 0.1.6.

* tarball
  - As the upstream ships bzip2 compressed tarball, please use it.

* BuildRequires:
  - Currently mono-core is not available on ppc64. So
    this package needs 'ExcludeArch: ppc64'.

* Timestamps
  - To keep timestamps on installed files, please consider to use:
------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
------------------------------------------------------------------
    This method usually works for recent autotool based Makefiles.

* Installed directory
  - Currently this package installs somefiles under %{_prefix}/lib/%{name},
    which is wrong for 64 bits machine (x86_64, where %{_prefix}/lib
    is /usr/lib while %{_libdir} is /usr/lib64).
    Please apply a patch so that this package use %{_libdir}/%{name}

* Directory ownership issue
  - Please make it sure that all directories created when installing
    this package are owned correctly by this package.
    Currently %{_libdir}/%{name}, %{_datadir}/%{name} are not owned by
    any packages.

* GTK icon cache update
  - As this package installs icons under %_datadir/icons/hicolor, please
    follow
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

* defattr
  - Please unify defattr usage to %defattr(-,root,root,-)

* Requires
  - It seems that this package needs some Requires:
    On my system:
---------------------------------------------------------------
[tasaka1@localhost ~]$ tasque 

** (Tasque.exe:5510): WARNING **: The following assembly referenced from
/usr/lib/tasque/Tasque.exe could not be loaded:
     Assembly:   gnome-sharp    (assemblyref_index=2)
     Version:    2.16.0.0
     Public Key: 35e10195dab3c99f
The assembly was not found in the Global Assembly Cache, a path listed in the
MONO_PATH environment variable, or in the location of the executing assembly
(/usr/lib/tasque/).


** (Tasque.exe:5510): WARNING **: Could not load file or assembly 'gnome-sharp,
Version=2.16.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f' or one of
its dependencies.

Unhandled Exception: System.TypeLoadException: Could not load type
'Tasque.Application' from assembly 'Tasque, Version=0.0.0.0, Culture=neutral'.
---------------------------------------------------------------

Please make it sure that you change the release number of the spec file every time
you modify your spec file when version number does not change.

Thanks for the feedback. I have implemented all suggestions excluding

> * Installed directory
>   - Currently this package installs somefiles under %{_prefix}/lib/%{name},
>     which is wrong for 64 bits machine (x86_64, where %{_prefix}/lib
>     is /usr/lib while %{_libdir} is /usr/lib64).
>     Please apply a patch so that this package use %{_libdir}/%{name}

I had some difficulty with this one.  Any suggestions?  It appears that there is
already an upstream bug filed on this:

http://bugzilla.gnome.org/show_bug.cgi?id=540983

The new files are here:
http://kaylor.info/fedora/SPEC/tasque.spec
http://kaylor.info/fedora/SRPM/tasque-0.1.6-1.fc9.src.rpm

For 0.1.6-1:

* Requires
  - Umm...
------------------------------------------------------------------------
$ tasque 

** (Tasque.exe:14041): WARNING **: The following assembly referenced from
/usr/lib/tasque/Tasque.exe could not be loaded:
     Assembly:   gdk-sharp    (assemblyref_index=5)
     Version:    2.12.0.0
     Public Key: 35e10195dab3c99f
The assembly was not found in the Global Assembly Cache, a path listed in the
MONO_PATH environment variable, or in the location of the executing assembly
(/usr/lib/tasque/).


** (Tasque.exe:14041): WARNING **: Could not load file or assembly 'gdk-sharp,
Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f' or one of
its dependencies.

Unhandled Exception: System.TypeLoadException: Could not load type
'Tasque.Application' from assembly 'Tasque, Version=0.0.0.0, Culture=neutral'.
-------------------------------------------------------------------------
    What am I missing??

* debuginfo issue
  - Since this is mono package and rpmbuild creates empty debuginfo rpm
    which is not usable, please follow:
   
https://fedoraproject.org/wiki/Packaging/Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_other_reasons

* 64 bits issue
  - Perhaps the following would work for 64 bits issue (at least
    build passes)
--------------------------------------------
%prep
%setup -q
grep -rl '/lib' . | \
	xargs sed -i.libdir \
	-e 's|\$(prefix)/lib|\$(libdir)|' \
	-e 's|@prefix@/lib|@libdir@|'
sed -i.rpath -e '\|sys_lib_dlsearch_path_spec|s|/usr/lib |/usr/lib /lib64
/usr/lib64 |' \
	configure
--------------------------------------------

* Documents
  - Please add the following files to %doc.
--------------------------------------------
AUTHORS
COPYING
ChangeLog
MAINTAINERS
README
--------------------------------------------

ping?

(In reply to comment #4)
> ping?

I'm back with some updates:
http://kaylor.info/fedora/SPEC/tasque.spec
http://kaylor.info/fedora/SRPM/tasque-0.1.6-2.fc9.src.rpm

The only concern that might not be fully addressed are the Mono deps in
Requires.  I've added gtk-sharp2 to fix your error but there could be others. 
When I get a chance, I'll test this on a machine that doesn't have Mono yet.

For 0.1.6-2:

* Dependency
  - Okay, it seems to work now (perhaps rawhide mono was just broken...)
    However currently I get the message like below:
-------------------------------------------------------------
[tasaka1@localhost tasque]$ tasque 

** (Tasque:16280): WARNING **: The following assembly referenced from
/usr/lib/tasque/Tasque.exe could not be loaded:
     Assembly:   NDesk.DBus.GLib    (assemblyref_index=8)
     Version:    1.0.0.0
     Public Key: f6716e4f9b2ed099
The assembly was not found in the Global Assembly Cache, a path listed in the
MONO_PATH environment variable, or in the location of the executing assembly
(/usr/lib/tasque/).


** (Tasque:16280): WARNING **: Could not load file or assembly 'NDesk.DBus.GLib,
Version=1.0.0.0, Culture=neutral, PublicKeyToken=f6716e4f9b2ed099' or one of its
dependencies.

** (Tasque:16280): WARNING **: Missing method Init in assembly
/usr/lib/tasque/Tasque.exe, type NDesk.DBus.BusG
[Debug]: Tasque remote control disabled (DBus exception): Could not load file or
assembly 'NDesk.DBus.GLib, Version=1.0.0.0, Culture=neutral,
PublicKeyToken=f6716e4f9b2ed099' or one of its dependencies.
[Debug]: Found Available Backend: Tasque.Backends.RtmBackend.RtmBackend
-------------------------------------------------------------
    Perhaps adding "Requires: ndesk-dbus-glib" is preferable.

  - Also, for directory ownership issue (%{_datadir}/dbus-1/services/), 
    it may be preferable that you write the explicit dependency: "Requires: dbus".

* Desktop files
  - Please remove the category "X-SuSE-Core-Office" from the desktop file
    (as we are not on SuSE).

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

(In reply to comment #6)
> For 0.1.6-2:
> 
> * Dependency
>   - Okay, it seems to work now (perhaps rawhide mono was just broken...)
>     However currently I get the message like below:
> -------------------------------------------------------------
> [tasaka1@localhost tasque]$ tasque 
> 
> ** (Tasque:16280): WARNING **: The following assembly referenced from
> /usr/lib/tasque/Tasque.exe could not be loaded:
>      Assembly:   NDesk.DBus.GLib    (assemblyref_index=8)
>      Version:    1.0.0.0
>      Public Key: f6716e4f9b2ed099
> The assembly was not found in the Global Assembly Cache, a path listed in the
> MONO_PATH environment variable, or in the location of the executing assembly
> (/usr/lib/tasque/).
> 
> 
> ** (Tasque:16280): WARNING **: Could not load file or assembly 'NDesk.DBus.GLib,
> Version=1.0.0.0, Culture=neutral, PublicKeyToken=f6716e4f9b2ed099' or one of its
> dependencies.
> 
> ** (Tasque:16280): WARNING **: Missing method Init in assembly
> /usr/lib/tasque/Tasque.exe, type NDesk.DBus.BusG
> [Debug]: Tasque remote control disabled (DBus exception): Could not load file or
> assembly 'NDesk.DBus.GLib, Version=1.0.0.0, Culture=neutral,
> PublicKeyToken=f6716e4f9b2ed099' or one of its dependencies.
> [Debug]: Found Available Backend: Tasque.Backends.RtmBackend.RtmBackend
> -------------------------------------------------------------
>     Perhaps adding "Requires: ndesk-dbus-glib" is preferable.
> 
>   - Also, for directory ownership issue (%{_datadir}/dbus-1/services/), 
>     it may be preferable that you write the explicit dependency: "Requires: dbus".
> 
> * Desktop files
>   - Please remove the category "X-SuSE-Core-Office" from the desktop file
>     (as we are not on SuSE).
> 
> Then:
> -------------------------------------------------------------
> NOTE: Before being sponsored:
> 
> This package will be accepted with another few work. 
> But before I accept this package, someone (I am a candidate) 
> must sponsor you.
> 
> Once you are sponsored, you have the right to review other 
> submitters' review requests and approve the packages formally. 
> For this reason, the person who want to be sponsored (like you) 
> are required to "show that you have an understanding 
> of the process and of the packaging guidelines" as is described
> on :
> http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
> 
> Usually there are two ways to show this.
> A. submit other review requests with enough quality.
> B. Do a "pre-review" of other person's review request
>    (at the time you are not sponsored, you cannot do
>    a formal review)
> 
> When you have submitted a new review request or have pre-reviewed other 
> person's review request, please write the bug number on this bug report 
> so that I can check your comments or review request.
> 
> Fedora package collection review requests which are waiting for someone to
> review can be checked on:
> http://fedoraproject.org/PackageReviewStatus/NEW.html
> (NOTE: please don't choose "Merge Review")
> 
> 
> Review guidelines are described mainly on:
> http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
> http://fedoraproject.org/wiki/Packaging/Guidelines
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
> ------------------------------------------------------------
> 

Latest revision:
http://kaylor.info/fedora/SPEC/tasque.spec
http://kaylor.info/fedora/SRPM/tasque-0.1.6-3.fc9.src.rpm

ndesk-dbus-glib is definitely preferable.  I tried installing revision 2 on a
clean Fedora 9 live usb and the program started but would later crash.

The SuSE reference is now removed.

I noticed my last post was not clear.  Without ndesk-dbus-glib, tasque would
start and later crash.  With ndesk-dbus-glib, it ran fine.

Oh, one more point:

* Installing desktop file
  When installing desktop file, "desktop-file-install" command (BR:
desktop-file-utils
  is needed) must be called. Please check:
  http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

Now I will wait for your another review request or a pre-review.

ping?

I've had a busy couple of weeks but here is an update with properly installed
desktop file:

http://kaylor.info/fedora/SPEC/tasque.spec
http://kaylor.info/fedora/SRPM/tasque-0.1.6-4.fc9.src.rpm

Thanks for your feedback & patience. Now on to finding something to review or
another program to package.

Okay, now this package itself is good. So I will wait for your another review
request
or pre-review of other person's review requests.

ping?

ping again?

Again ping?

Personal matters are eating up a lot of my time and I hope to get back to this ASAP.

Update to 0.1.7:
http://kaylor.info/fedora/SPEC/tasque.spec
http://kaylor.info/fedora/SRPM/tasque-0.1.7-1.fc9.src.rpm

So would you do a pre-review of other person's review request (or submit
another review request) as I wrote in comment 6?

ping?

ping again?

ping again??

I will close this bug as NOTABUG if no response is received from
the reporter within ONE WEEK.

I am going to review this package: https://bugzilla.redhat.com/show_bug.cgi?id=467627.

Add upstream bug link to patch file:
http://www.kaylor.info/fedora/SPEC/tasque.spec
http://www.kaylor.info/fedora/SRPM/tasque-0.1.7-2.fc9.src.rpm

Just a question (but maybe important).

It seems that you are using Fedora 9 (according to the srpm name).
If so, can you rebuild your srpm on Fedora 9? (Note that I am asking
on F-9. on F-10 this surely builds).

For 0.1.7-2:

* BuildRequires
  - build.log says:
-------------------------------------------------
   412  checking for NOTIFY_SHARP... 
   413  no
-------------------------------------------------
    Now on F-10+ Fedora has "notify-sharp" (imported on Oct-11),
    so at least add
-------------------------------------------------
%if 0%{?fedora} >= 10
BuildRequires:	notify-sharp-devel
%endif
-------------------------------------------------
    Maybe "Requires: notify-sharp" should also be added on F-10+.

* Documents
  - Please also add "NEWS" file to %doc.

! For F-9 build
  - If you are using F-9 and you can rebuild your package on F-9, would you
    tell me if gnome-sharp is updated?

(In reply to comment #26)
> For 0.1.7-2:
> 
> * BuildRequires
>   - build.log says:
> -------------------------------------------------
>    412  checking for NOTIFY_SHARP... 
>    413  no
> -------------------------------------------------
>     Now on F-10+ Fedora has "notify-sharp" (imported on Oct-11),
>     so at least add
> -------------------------------------------------
> %if 0%{?fedora} >= 10
> BuildRequires: notify-sharp-devel
> %endif
> -------------------------------------------------
>     Maybe "Requires: notify-sharp" should also be added on F-10+.
 
I added both.  It seems to me that if the build needs notify-sharp, the package will.  I can test this better when I have set up a F10 machine.

> * Documents
>   - Please also add "NEWS" file to %doc.> 

Added both NEWS and TODO

> ! For F-9 build
>   - If you are using F-9 and you can rebuild your package on F-9, would you
>     tell me if gnome-sharp is updated?

I am using and can build on F9.  The gnome-sharp package is an official package (gnome-sharp-2.16.1-1.fc9.x86_64).

Updated Tasque packages at:
http://www.kaylor.info/fedora/SRPM/tasque-0.1.7-3.fc9.src.rpm
http://www.kaylor.info/fedora/SPEC/tasque.spec

(In reply to comment #27)
> (In reply to comment #26)
> > ! For F-9 build
> >   - If you are using F-9 and you can rebuild your package on F-9, would you
> >     tell me if gnome-sharp is updated?
> 
> I am using and can build on F9.  The gnome-sharp package is an official package
> (gnome-sharp-2.16.1-1.fc9.x86_64).

Okay, then would you tell me what
$ rpm -q gtk-sharp2
return?

(In reply to comment #28)
> Okay, then would you tell me what
> $ rpm -q gtk-sharp2
> return?

Don't worry. Now F-9 buildroot is fixed by Xavier (bug 468055).
Now:
+ This package itself is now okay
+ You seem to have chosen almost good package for your pre-review, however
  I will approve it.

--------------------------------------------------------------
    This package (tasque) is APPROVED by mtasaka
--------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Install the Client Tools (Koji) ".

Now I am sponsoring you.

If you want to import this package into Fedora 8/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).


Removing NEEDSPONSOR.

If you have questions, please ask me.

(In reply to comment #28)
> (In reply to comment #27)
> > (In reply to comment #26)
> > > ! For F-9 build
> > >   - If you are using F-9 and you can rebuild your package on F-9, would you
> > >     tell me if gnome-sharp is updated?
> > 
> > I am using and can build on F9.  The gnome-sharp package is an official package
> > (gnome-sharp-2.16.1-1.fc9.x86_64).
> 
> Okay, then would you tell me what
> $ rpm -q gtk-sharp2
> return?

gtk-sharp2-2.10.3-3.fc9.x86_64

(In reply to comment #30)
> > Okay, then would you tell me what
> > $ rpm -q gtk-sharp2
> > return?
> 
> gtk-sharp2-2.10.3-3.fc9.x86_64

Thanks. Actually dist-f9-build uses gtk-sharp2-2.12.1-1.fc9,
which were causing dependency problem on dist-f9-build,
now fixed by gnome-sharp maintainer (bug 468055).

New Package CVS Request
=======================
Package Name: tasque
Short Description: A simple task management app (TODO list) for the Linux Desktop
Owners: dkaylor
Branches: f-9
InitialCC: mtasaka

> Now:
> + This package itself is now okay
> + You seem to have chosen almost good package for your pre-review, however
>   I will approve it.
> 
> --------------------------------------------------------------
>     This package (tasque) is APPROVED by mtasaka
> --------------------------------------------------------------
> 
> Please follow the procedure written on:
> http://fedoraproject.org/wiki/PackageMaintainers/Join
> from "Install the Client Tools (Koji) ".
> 
> Now I am sponsoring you.
> 
> If you want to import this package into Fedora 8/9, you also have
> to look at
> http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
> (after once you rebuilt this package on koji Fedora rebuilding system).
> 
> 
> Removing NEEDSPONSOR.
> 
> If you have questions, please ask me.

Thanks.  I just did a Koji build & submitted my CVS request.  For now, I listed only f-9 but maybe I should have included f-10?

(In reply to comment #33)
> Thanks.  I just did a Koji build & submitted my CVS request.  For now, I listed
> only f-9 but maybe I should have included f-10?

F-10 branch is also created as "devel" directory in this case so 
don't worry (unless you need early branching).

(In reply to comment #34)
> (In reply to comment #33)
> > Thanks.  I just did a Koji build & submitted my CVS request.  For now, I listed
> > only f-9 but maybe I should have included f-10?
> 
> F-10 branch is also created as "devel" directory in this case so 
> don't worry (unless you need early branching).

OK.  I'll look at adding it closer to the final release date - the f-10 build does succeed in Koji.

I am having trouble with CVS:

[dkaylor@localhost ~]$ ls  .fedora*
.fedora.cert  .fedora-server-ca.cert  .fedora-upload-ca.cert
[dkaylor@localhost ~]$ fedora-cvs tasque
Checking out tasque from fedora cvs:
Error: Permission denied (publickey).
cvs [checkout aborted]: end of file from server (consult above messages if any)

Is my request correct or is something else not set up?

Please make it sure that you have ssh keys and have uploaded
ssh public key to Fedora Account System:

https://fedoraproject.org/wiki/Infrastructure/AccountSystem#What_is_an_SSH_key.2C_and_why_do_I_need_one.3F
https://fedoraproject.org/wiki/Cryptography

By the way tasque module is not ready yet on Fedora CVS.

CVS Done

tasque-0.1.7-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/tasque-0.1.7-3.fc9

Okay.

* When you think the submitted F-9 package can be moved from testing to stable
  repository please revisit bodhi interface and modify (edit) your push
  request.

* dist-f10 repo got frozen before you rebuilt this package on F-10
  branch so this package won't be pushed into F-10 branch automatically.

  - Later bodhi ( http://admin.fedoraproject.org/updates/ ) will begin
    to accept F-10 packages update requests (such announce will be
    sent to fedora-devel-list mailing list).
    After that please submit push request also for F-10 branch on
    bodhi
  - And later mass branching will be executed  F-10 directory
    will be newly created on tasque module in Fedora CVS. After that
    please rebuild your package (tasque) for "devel" branch (at
    this point devel now points to F-11, not F-10. Currently
    "devel" branch points to F-10).

Closing as NEXTRELEASE.

tasque-0.1.7-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

tasque-0.1.7-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/tasque-0.1.7-3.fc10

tasque-0.1.7-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: tasque
New Branches: f-10
Owners: dkaylor

There is already a f10 branch here. 

Make sure you are doing 'cvs update -d' to pick up the new directory from the mass branch.

tasque-0.1.8-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/tasque-0.1.8-1.fc10

tasque-0.1.8-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/tasque-0.1.8-1.fc9

tasque-0.1.8-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

tasque-0.1.8-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.