Bug 450136

Summary:	dlm: check for null in device_write [rhel-5.3]
Product:	Red Hat Enterprise Linux 5	Reporter:	David Teigland <teigland>
Component:	kernel	Assignee:	Don Zickus <dzickus>
Status:	CLOSED ERRATA	QA Contact:	Cluster QE <mspqa-list>
Severity:	low	Docs Contact:
Priority:	low
Version:	5.3	CC:	ccaulfie, edamato, lwang, mgahagan, yamato
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-01-20 20:22:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Teigland 2008-06-05 14:56:01 UTC

Description of problem:

If `device_write' method is called via "dlm-control",
file->private_data is NULL. (See ctl_device_open() in
user.c. ) Through proc->flags is read.

This causes a kernel oops.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 David Teigland 2008-06-05 15:41:57 UTC

fixed in upstream commit:

From f1605096f1fde64403edcb9e18605174a64e1c55 Mon Sep 17 00:00:00 2001
From: Masatake YAMATO <yamato>
Date: Wed, 28 May 2008 14:45:10 +0900
Subject: [PATCH] dlm: check for null in device_write

If `device_write' method is called via "dlm-control",
file->private_data is NULL. (See ctl_device_open() in
user.c. ) Through proc->flags is read.

Signed-off-by: Masatake YAMATO <yamato>
Signed-off-by: David Teigland <teigland>

Comment 2 RHEL Program Management 2008-06-05 16:34:23 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 David Teigland 2008-06-05 16:35:39 UTC

The commit referenced in comment 1 is from linux-next, pending the merge
window for 2.6.27, so the commit id is not permanent.

Comment 4 David Teigland 2008-06-05 19:27:03 UTC

patch posted to rhkernel-list

http://post-office.corp.redhat.com/archives/rhkernel-list/2008-June/msg00090.html

Comment 6 Don Zickus 2008-07-16 15:48:24 UTC

in kernel-2.6.18-97.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 9 Mike Gahagan 2008-12-09 19:48:34 UTC

confirmed fix is in the -125 kernel.

Comment 11 errata-xmlrpc 2009-01-20 20:22:11 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html