Bug 450222
Summary: | Denyhosts purge command cannot find configuration file | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | srh <srhtemp1> |
Component: | denyhosts | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 9 | CC: | dennis |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | i386 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-07-05 18:41:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
srh
2008-06-05 23:00:20 UTC
Well, the default config file in the denyhosts executable is /usr/share/denyhosts/denyhosts.cfg; Fedora uses /etc/denyhosts.conf but of course you're welcome to use whatever config file you like. I suppose it's theoretically possible to patch the denyhosts executable but honestly I try to patch the upstream sources as little as I can get away with. I don't really see this as a bug, but I'll give it some thought. If Fedora has decided to actively change the default config to /etc/denyhosts.conf (which is a reasonable action for how this distro organises things), then ALL default aspects of denyhosts should point to this. This particular config file is where the action happens, not a copy of the config file pasted elsewhere. That is just confusing. Well, Fedora hasn't decided to actively change the default config to /etc/denyhosts.conf. In fact, the fact that it Fedora doesn't do that is the reason you've opened this ticket. The initscripts and crontabs all specify a config file location and don't rely on the default setting. You are asking that we introduce a variance from the upstream sources. If you installed the Fedora package, tossed the initscript and decided to roll your own, you wouldn't be able to use existing documentation because Fedora would have changed the behavior of the program. I indicated that I would give this some thought, and I will do that. I will consult other Fedora packagers and get their input. I have to balance your valid concerns against the above valid concerns, and I promise I won't make a snap judgment. Just give me some time to consider the options. No rush at all in the decision making. I can work around the problem easily enough meanwhile. I do not actually mind how the system works in the end, so long as it is well thought out, logical and consistent. Thats what all software aspires to. Following upstream closely is also very good in general. I only started this bug as it appears there is a possibly inconsistency (previously unnoticed??) as to where different software tools look for the config file. However, it makes sense to have only one config file, and also for the --purge command to work, as explained on the denyhosts website. I did some work on denyhosts today. Regarding your problem, inspection reveals that what you want to work wouldn't work even if we hadn't used a different name for the configuration file, because denyhosts.py only looks for the config file in the current directory. I just patched it to default to /etc/denyhosts.conf. Given the mostly useless default behavior I think there's a low possibility of anyone depending on it, so I feel confident in pushing this to F9. Please do test and comment on the update as appropriate. denyhosts-2.6-10.fc9 has been submitted as an update for Fedora 9 denyhosts-2.6-10.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update denyhosts'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-6008 I have installed and from updates-testing. The command "/usr/bin/denyhosts.py --purge" now works as expected with the default /etc/denyhosts.conf. Thanks for fixing this issue for Fedora. Perhaps this issue could be forwarded upstream, so some easy upstream solution could be implemented. Thanks for testing; don't forget to make a note in the update system so that this can be pushed to the stable repository. denyhosts-2.6-10.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |