Bug 450223
| Summary: | Review Request: mediawiki-SpecialInterwiki - An extension to provide an interwiki management system | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nigel Jones <dev> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | mediawiki-SpecialInterwiki-0-0.3.20080606svn.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-26 12:05:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nigel Jones
2008-06-05 23:08:14 UTC
Spec URL: http://dev.nigelj.com/SRPMS/mediawiki-SpecialInterwiki.spec SRPM URL: http://dev.nigelj.com/SRPMS/mediawiki-SpecialInterwiki-0-0.2.20080606svn.fc9.src.rpm I've done away with the tarball (how silly) and managed to do everything else, I forgot to cleanup %prep though, I'll do this during import. A three-file package; not much to it. All I can say is that %prep can go entirely, and the Source files should be commented with the URLs. (I know you can't provide the URLs directly on the Source: lines due to URL parameters needing to be passed.) Trivial issues; fix them up when you import. * source files match upstream (checked by manually downloading from upstream website) * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * BuildRequires are proper (none; nothing to build) * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: mediawiki-SpecialInterwiki = 0-0.2.20080606svn.fc10 = mediawiki < 1.11 * %check is present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED (In reply to comment #2) > A three-file package; not much to it. > > All I can say is that %prep can go entirely, and the Source files should be > commented with the URLs. (I know you can't provide the URLs directly on the > Source: lines due to URL parameters needing to be passed.) Trivial issues; fix > them up when you import. > Yeah, I noticed them when I uploaded that revision, just cosmetic :) New Package CVS Request ======================= Package Name: mediawiki-SpecialInterwiki Short Description: An extension to provide an interwiki management system Owners: nigelj Branches: F-8 F-9 EL-4 EL-5 Cvsextras Commits: yes cvs done. mediawiki-SpecialInterwiki-0-0.3.20080606svn.fc9 has been submitted as an update for Fedora 9 mediawiki-SpecialInterwiki-0-0.3.20080606svn.fc8 has been submitted as an update for Fedora 8 mediawiki-SpecialInterwiki-0-0.3.20080606svn.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. mediawiki-SpecialInterwiki-0-0.3.20080606svn.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |