Bug 450427
Summary: | bad grep'ing of network configuration scripts | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | JW <ohtmvyyn> |
Component: | initscripts | Assignee: | Bill Nottingham <notting> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 8 | CC: | rvokal |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-06-09 14:22:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
JW
2008-06-08 05:59:05 UTC
Having configurations include other configurations is not guaranteed to work, and never has been. Configurations aren't sources so that they can be found instead of polluting the environment, as doing otherwise involves playing tricks with subshells and pipes. So why do ifup-* all invoke 'source_config()' which actually sources the config files as shell sources. If what you say is true, then you have exposed an enormous bug in all of those ifup-* scripts. They must be changed because of what you have just decreed. This bug can therefore be restated as: All ifup-* scripts must no longer invoke source_config() and must instead do some 'LC_All=C grep this and that' so as to conform to the better way of doing things. Viva la grep. Down with bash! You misunderstood what I said, but thanks anyway. If you want to write a patch to source via a subshell and then pass the needed information back over a pipe (or whatever), go ahead. But configurations that directly include other configurations are *not* supported, any more than configurations that define and override functions used by the network scripts. |