Bug 450476
| Summary: | InfiniBand Connection Management library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Doug Ledford <dledford> |
| Component: | Package Review | Assignee: | Ed Hill <ed> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | Flags: | ed:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://people.redhat.com/dledford/Infiniband/f10/SRPMS/libibcm-1.0.2-1.fc10.src.rpm | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-10 11:51:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 450470 | ||
| Bug Blocks: | |||
|
Description
Doug Ledford
2008-06-08 23:59:59 UTC
Here is a quick review:
GOOD:
+ source matches upstream (SHA1SUM):
bd18cd1c105275feb25461f659a3ad94e7c5db8c libibcm-1.0.2.tar.gz
bd18cd1c105275feb25461f659a3ad94e7c5db8c libibcm-1.0.2.tar.gz.UP
+ license is correct and correctly included
+ builds in mock for F8 x86_64
+ rpmlint output is just some ignore-able warnings:
libibcm.x86_64: E: zero-length /usr/share/doc/libibcm-1.0.2/ChangeLog
libibcm-devel.x86_64: W: no-documentation
libibcm-static.x86_64: W: no-documentation
+ naming OK
+ spec legible and macros look sane
+ shared libs (ldconfig) looks good
+ permissions OK
+ dir ownership OK
+ static libs are correctly in *-static
I don't see any blockers here so its APPROVED.
Ooops, I overlooked the empty ChangeLog file! Please just remove it from the package. ChangeLog file removed from %doc list. New packages uploaded over top of the old packages, so you might need to refresh your web/proxy cache to get the new files from the site. Thank you -- its APPROVED. New Package CVS Request ======================= Package Name: libibcm Short Description: InfiniBand Connection Management library Owners: dledford Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. |