Bug 450477
| Summary: | RDMA Connection Management library/API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Doug Ledford <dledford> |
| Component: | Package Review | Assignee: | Shawn Starr <shawn.starr> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | shawn.starr:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | noarch | ||
| OS: | Linux | ||
| URL: | http://people.redhat.com/dledford/Infiniband/f10/SRPMS/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-25 16:31:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 450470 | ||
| Bug Blocks: | |||
|
Description
Doug Ledford
2008-06-09 00:00:54 UTC
Er, meant to edit comment text and accidentally triggered the web browser to post early instead. Anyway, this is the librdmacm library. It's the most commonly used user space API for abstracting out the InfiniBand connection process and making it act, as much as possible, like a normal sockets based connection. It's highly useful and make RDMA programming not quite so horrible. REVIEW
======
GOOD:
+ Mock build successful
INFO: Done(librdmacm-1.0.7-1.fc10.src.rpm) Config(default) 6 minutes 33 seconds
INFO: Results and/or logs in: /var/lib/mock//fedora-rawhide-i386/result
Wrote: /builddir/build/RPMS/librdmacm-1.0.7-1.fc10.i386.rpm
Wrote: /builddir/build/RPMS/librdmacm-devel-1.0.7-1.fc10.i386.rpm
Wrote: /builddir/build/RPMS/librdmacm-utils-1.0.7-1.fc10.i386.rpm
Wrote: /builddir/build/RPMS/librdmacm-static-1.0.7-1.fc10.i386.rpm
Wrote: /builddir/build/RPMS/librdmacm-debuginfo-1.0.7-1.fc10.i386.rpm
rpmlint
-------
+ librdmacm-utils: No errors/warnings
+ librdmacm-devel: No errors/warnings
! rpmlint reports the following warnings/errors:
? librdmacm.i386: E: zero-length /usr/share/doc/librdmacm-1.0.7/ChangeLog
? Not sure what we can do about that, It's upstream's problem for not
putting in a valid ChangeLog.
+ librdmacm-static.i386: W: no-documentation
+ No doc for static is just fine.
+ Naming of RPMs generated is ok
+ License is fine (GPLv2 and BSD)
+ Permissions/ownership/dirs is ok
Assuming we can't do anything about the ChangeLog, these RPMs look OK to me for
submission.
Please comment, then we'll mark this for cvs.
For a 0 length changelog file, Ed had me just remove the file from the %doc list. If they haven't bothered to use the file to date, they likely never will, no sense keeping it around. I'll make that change. New rpms copied over the top of the old ones. Looks good, approved! New Package CVS Request ======================= Package Name: librdmacm Short Description: RDMA IP based Connection Management library Owners: dledford Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. |