Bug 450835
Summary: | gfs_fsck build warnings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steve Whitehouse <swhiteho> | ||||||
Component: | GFS | Assignee: | Robert Peterson <rpeterso> | ||||||
Status: | CLOSED UPSTREAM | QA Contact: | |||||||
Severity: | low | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | rawhide | CC: | fdinitto | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2008-06-19 05:23:03 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Steve Whitehouse
2008-06-11 09:40:13 UTC
Created attachment 309140 [details]
Proposed patch
Here is the patch I'm planning to push.
Tested on x86_64 and ia64. Now pushed to master and STABLE2 branches. Hi Bob, looks good on 64bit userland. 32bit: gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -Werror -Wall -Wformat=2 -MMD -O2 -g -I/usr/src/upstream/cluster/rhcluster/cluster/make -DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\" -DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4 -DRELEASE_VERSION=\"1213247212\" -Wall -Wformat=2 -MMD -O2 -g -I/usr/src/upstream/cluster/rhcluster/cluster/make -DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\" -DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4 -DRELEASE_VERSION=\"1213247212\" -D_FILE_OFFSET_BITS=64 -DHELPER_PROGRAM -I/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_fsck/../include -I/usr/include -c -o super.o /usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_fsck/super.c cc1: warnings being treated as errors /usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_fsck/super.c: In function ‘ri_update’: /usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_fsck/super.c:1163: error: this decimal constant is unsigned only in ISO C90 make[1]: *** [super.o] Error 1 make[1]: Leaving directory `/usr/src/upstream/cluster/rhcluster/obj-i686/gfs/gfs_fsck' make: *** [all] Error 2 It's the only warning/error in gfs_fsck. Fabio Created attachment 309213 [details]
Addendum patch
This patch fixes the super.c problem on my 32-bit box at least.
Now pushed to master and STABLE2.
|